dtimg/am57xx_evm_defconfig: Rename dtimg to adtimg
authorEugeniu Rosca <roscaeugeniu@gmail.com>
Tue, 24 Dec 2019 16:51:06 +0000 (17:51 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 10 Jan 2020 19:18:26 +0000 (14:18 -0500)
Rename the existing 'dtimg' command to 'adtimg', in order to:
 - Suggest the Android origins and scope
 - Be consistent with the upcoming 'abootimg' command (naming
   suggested by Simon [*])

The change in _not_ backward compatible, but its benefits outweigh its
downsides, given that we don't expect active users of 'dtimg' today.

Perform the rename in several steps:
 1. Rename *.c file and Kconfig symbol. This should allow
    'git log --follow' to properly track the history of 'adtimg.c'
 2. 's/dtimg/adtimg/g' in the internal namespace of 'adtimg.c'

ELF comparison [**] before and after shows no functional change.

[*] https://patchwork.ozlabs.org/patch/1182212/#2291600
[**] diff -u <(objdump -d cmd/dtimg.o) <(objdump -d cmd/adtimg.o)

Cc: Tom Rini <trini@konsulko.com>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Simon Glass<sjg@chromium.org>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
cmd/Kconfig
cmd/Makefile
cmd/adtimg.c [new file with mode: 0644]
cmd/dtimg.c [deleted file]
common/Makefile
configs/am57xx_evm_defconfig
configs/am57xx_hs_evm_defconfig
configs/am57xx_hs_evm_usb_defconfig

index 26c6551ed6162273049cfd660b4b44c69d8bc23e..298feae24d3fee427ce5e753562ac29ca0d799d2 100644 (file)
@@ -364,8 +364,8 @@ config CMD_BOOTMENU
        help
          Add an ANSI terminal boot menu command.
 
-config CMD_DTIMG
-       bool "dtimg"
+config CMD_ADTIMG
+       bool "adtimg"
        help
          Android DTB/DTBO image manipulation commands. Read dtb/dtbo files from
          image into RAM, dump image structure information, etc. Those dtb/dtbo
index 8df39f3a19f1737d84f8a966d40d8bb70197d50b..ecf687d49f380397beb065a21747cacbd00c7982 100644 (file)
@@ -47,7 +47,7 @@ obj-$(CONFIG_CMD_SOUND) += sound.o
 ifdef CONFIG_POST
 obj-$(CONFIG_CMD_DIAG) += diag.o
 endif
-obj-$(CONFIG_CMD_DTIMG) += dtimg.o
+obj-$(CONFIG_CMD_ADTIMG) += adtimg.o
 obj-$(CONFIG_CMD_ECHO) += echo.o
 obj-$(CONFIG_ENV_IS_IN_EEPROM) += eeprom.o
 obj-$(CONFIG_CMD_EEPROM) += eeprom.o
diff --git a/cmd/adtimg.c b/cmd/adtimg.c
new file mode 100644 (file)
index 0000000..6c5d53c
--- /dev/null
@@ -0,0 +1,142 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2018 Linaro Ltd.
+ * Sam Protsenko <semen.protsenko@linaro.org>
+ */
+
+#include <env.h>
+#include <image-android-dt.h>
+#include <common.h>
+
+enum cmd_dtimg_info {
+       CMD_DTIMG_START = 0,
+       CMD_DTIMG_SIZE,
+};
+
+static int do_dtimg_dump(cmd_tbl_t *cmdtp, int flag, int argc,
+                        char * const argv[])
+{
+       char *endp;
+       ulong hdr_addr;
+
+       if (argc != 2)
+               return CMD_RET_USAGE;
+
+       hdr_addr = simple_strtoul(argv[1], &endp, 16);
+       if (*endp != '\0') {
+               printf("Error: Wrong image address\n");
+               return CMD_RET_FAILURE;
+       }
+
+       if (!android_dt_check_header(hdr_addr)) {
+               printf("Error: DT image header is incorrect\n");
+               return CMD_RET_FAILURE;
+       }
+
+       android_dt_print_contents(hdr_addr);
+
+       return CMD_RET_SUCCESS;
+}
+
+static int dtimg_get_fdt(int argc, char * const argv[], enum cmd_dtimg_info cmd)
+{
+       ulong hdr_addr;
+       u32 index;
+       char *endp;
+       ulong fdt_addr;
+       u32 fdt_size;
+       char buf[65];
+
+       if (argc != 4)
+               return CMD_RET_USAGE;
+
+       hdr_addr = simple_strtoul(argv[1], &endp, 16);
+       if (*endp != '\0') {
+               printf("Error: Wrong image address\n");
+               return CMD_RET_FAILURE;
+       }
+
+       if (!android_dt_check_header(hdr_addr)) {
+               printf("Error: DT image header is incorrect\n");
+               return CMD_RET_FAILURE;
+       }
+
+       index = simple_strtoul(argv[2], &endp, 0);
+       if (*endp != '\0') {
+               printf("Error: Wrong index\n");
+               return CMD_RET_FAILURE;
+       }
+
+       if (!android_dt_get_fdt_by_index(hdr_addr, index, &fdt_addr, &fdt_size))
+               return CMD_RET_FAILURE;
+
+       switch (cmd) {
+       case CMD_DTIMG_START:
+               snprintf(buf, sizeof(buf), "%lx", fdt_addr);
+               break;
+       case CMD_DTIMG_SIZE:
+               snprintf(buf, sizeof(buf), "%x", fdt_size);
+               break;
+       default:
+               printf("Error: Unknown cmd_dtimg_info value: %d\n", cmd);
+               return CMD_RET_FAILURE;
+       }
+
+       env_set(argv[3], buf);
+
+       return CMD_RET_SUCCESS;
+}
+
+static int do_dtimg_start(cmd_tbl_t *cmdtp, int flag, int argc,
+                         char * const argv[])
+{
+       return dtimg_get_fdt(argc, argv, CMD_DTIMG_START);
+}
+
+static int do_dtimg_size(cmd_tbl_t *cmdtp, int flag, int argc,
+                        char * const argv[])
+{
+       return dtimg_get_fdt(argc, argv, CMD_DTIMG_SIZE);
+}
+
+static cmd_tbl_t cmd_dtimg_sub[] = {
+       U_BOOT_CMD_MKENT(dump, 2, 0, do_dtimg_dump, "", ""),
+       U_BOOT_CMD_MKENT(start, 4, 0, do_dtimg_start, "", ""),
+       U_BOOT_CMD_MKENT(size, 4, 0, do_dtimg_size, "", ""),
+};
+
+static int do_dtimg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+       cmd_tbl_t *cp;
+
+       cp = find_cmd_tbl(argv[1], cmd_dtimg_sub, ARRAY_SIZE(cmd_dtimg_sub));
+
+       /* Strip off leading 'dtimg' command argument */
+       argc--;
+       argv++;
+
+       if (!cp || argc > cp->maxargs)
+               return CMD_RET_USAGE;
+       if (flag == CMD_FLAG_REPEAT && !cmd_is_repeatable(cp))
+               return CMD_RET_SUCCESS;
+
+       return cp->cmd(cmdtp, flag, argc, argv);
+}
+
+U_BOOT_CMD(
+       dtimg, CONFIG_SYS_MAXARGS, 0, do_dtimg,
+       "manipulate dtb/dtbo Android image",
+       "dump <addr>\n"
+       "    - parse specified image and print its structure info\n"
+       "      <addr>: image address in RAM, in hex\n"
+       "dtimg start <addr> <index> <varname>\n"
+       "    - get address (hex) of FDT in the image, by index\n"
+       "      <addr>: image address in RAM, in hex\n"
+       "      <index>: index of desired FDT in the image\n"
+       "      <varname>: name of variable where to store address of FDT\n"
+       "dtimg size <addr> <index> <varname>\n"
+       "    - get size (hex, bytes) of FDT in the image, by index\n"
+       "      <addr>: image address in RAM, in hex\n"
+       "      <index>: index of desired FDT in the image\n"
+       "      <varname>: name of variable where to store size of FDT"
+);
diff --git a/cmd/dtimg.c b/cmd/dtimg.c
deleted file mode 100644 (file)
index 6c5d53c..0000000
+++ /dev/null
@@ -1,142 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * (C) Copyright 2018 Linaro Ltd.
- * Sam Protsenko <semen.protsenko@linaro.org>
- */
-
-#include <env.h>
-#include <image-android-dt.h>
-#include <common.h>
-
-enum cmd_dtimg_info {
-       CMD_DTIMG_START = 0,
-       CMD_DTIMG_SIZE,
-};
-
-static int do_dtimg_dump(cmd_tbl_t *cmdtp, int flag, int argc,
-                        char * const argv[])
-{
-       char *endp;
-       ulong hdr_addr;
-
-       if (argc != 2)
-               return CMD_RET_USAGE;
-
-       hdr_addr = simple_strtoul(argv[1], &endp, 16);
-       if (*endp != '\0') {
-               printf("Error: Wrong image address\n");
-               return CMD_RET_FAILURE;
-       }
-
-       if (!android_dt_check_header(hdr_addr)) {
-               printf("Error: DT image header is incorrect\n");
-               return CMD_RET_FAILURE;
-       }
-
-       android_dt_print_contents(hdr_addr);
-
-       return CMD_RET_SUCCESS;
-}
-
-static int dtimg_get_fdt(int argc, char * const argv[], enum cmd_dtimg_info cmd)
-{
-       ulong hdr_addr;
-       u32 index;
-       char *endp;
-       ulong fdt_addr;
-       u32 fdt_size;
-       char buf[65];
-
-       if (argc != 4)
-               return CMD_RET_USAGE;
-
-       hdr_addr = simple_strtoul(argv[1], &endp, 16);
-       if (*endp != '\0') {
-               printf("Error: Wrong image address\n");
-               return CMD_RET_FAILURE;
-       }
-
-       if (!android_dt_check_header(hdr_addr)) {
-               printf("Error: DT image header is incorrect\n");
-               return CMD_RET_FAILURE;
-       }
-
-       index = simple_strtoul(argv[2], &endp, 0);
-       if (*endp != '\0') {
-               printf("Error: Wrong index\n");
-               return CMD_RET_FAILURE;
-       }
-
-       if (!android_dt_get_fdt_by_index(hdr_addr, index, &fdt_addr, &fdt_size))
-               return CMD_RET_FAILURE;
-
-       switch (cmd) {
-       case CMD_DTIMG_START:
-               snprintf(buf, sizeof(buf), "%lx", fdt_addr);
-               break;
-       case CMD_DTIMG_SIZE:
-               snprintf(buf, sizeof(buf), "%x", fdt_size);
-               break;
-       default:
-               printf("Error: Unknown cmd_dtimg_info value: %d\n", cmd);
-               return CMD_RET_FAILURE;
-       }
-
-       env_set(argv[3], buf);
-
-       return CMD_RET_SUCCESS;
-}
-
-static int do_dtimg_start(cmd_tbl_t *cmdtp, int flag, int argc,
-                         char * const argv[])
-{
-       return dtimg_get_fdt(argc, argv, CMD_DTIMG_START);
-}
-
-static int do_dtimg_size(cmd_tbl_t *cmdtp, int flag, int argc,
-                        char * const argv[])
-{
-       return dtimg_get_fdt(argc, argv, CMD_DTIMG_SIZE);
-}
-
-static cmd_tbl_t cmd_dtimg_sub[] = {
-       U_BOOT_CMD_MKENT(dump, 2, 0, do_dtimg_dump, "", ""),
-       U_BOOT_CMD_MKENT(start, 4, 0, do_dtimg_start, "", ""),
-       U_BOOT_CMD_MKENT(size, 4, 0, do_dtimg_size, "", ""),
-};
-
-static int do_dtimg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
-{
-       cmd_tbl_t *cp;
-
-       cp = find_cmd_tbl(argv[1], cmd_dtimg_sub, ARRAY_SIZE(cmd_dtimg_sub));
-
-       /* Strip off leading 'dtimg' command argument */
-       argc--;
-       argv++;
-
-       if (!cp || argc > cp->maxargs)
-               return CMD_RET_USAGE;
-       if (flag == CMD_FLAG_REPEAT && !cmd_is_repeatable(cp))
-               return CMD_RET_SUCCESS;
-
-       return cp->cmd(cmdtp, flag, argc, argv);
-}
-
-U_BOOT_CMD(
-       dtimg, CONFIG_SYS_MAXARGS, 0, do_dtimg,
-       "manipulate dtb/dtbo Android image",
-       "dump <addr>\n"
-       "    - parse specified image and print its structure info\n"
-       "      <addr>: image address in RAM, in hex\n"
-       "dtimg start <addr> <index> <varname>\n"
-       "    - get address (hex) of FDT in the image, by index\n"
-       "      <addr>: image address in RAM, in hex\n"
-       "      <index>: index of desired FDT in the image\n"
-       "      <varname>: name of variable where to store address of FDT\n"
-       "dtimg size <addr> <index> <varname>\n"
-       "    - get size (hex, bytes) of FDT in the image, by index\n"
-       "      <addr>: image address in RAM, in hex\n"
-       "      <index>: index of desired FDT in the image\n"
-       "      <varname>: name of variable where to store size of FDT"
-);
index 302d8beaf356aad14f7ebd7f3e9c7eed711d3545..029cc0f2ce6b408ac79524cb744fc064c81b87e5 100644 (file)
@@ -117,7 +117,7 @@ obj-$(CONFIG_IO_TRACE) += iotrace.o
 obj-y += memsize.o
 obj-y += stdio.o
 
-obj-$(CONFIG_CMD_DTIMG) += image-android-dt.o
+obj-$(CONFIG_CMD_ADTIMG) += image-android-dt.o
 
 ifdef CONFIG_CMD_EEPROM_LAYOUT
 obj-y += eeprom/eeprom_field.o eeprom/eeprom_layout.o
index ae183e9b562c2e9fca22971b8fd52c7cba853f95..0c6a2e9193b9449d0088852183cc2f2a2e13234a 100644 (file)
@@ -29,7 +29,7 @@ CONFIG_SPL_OS_BOOT=y
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x40000
 CONFIG_SPL_YMODEM_SUPPORT=y
-CONFIG_CMD_DTIMG=y
+CONFIG_CMD_ADTIMG=y
 CONFIG_CMD_SPL=y
 CONFIG_CMD_BCB=y
 # CONFIG_CMD_FLASH is not set
index 800ec6c70b92d91fe958a40b79a4a75fa5f88777..3c57dfb031a9a5c945e81532a83e5082999c49b0 100644 (file)
@@ -32,7 +32,7 @@ CONFIG_SPL_DMA_SUPPORT=y
 # CONFIG_SPL_NAND_SUPPORT is not set
 CONFIG_SPL_SPI_LOAD=y
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x40000
-CONFIG_CMD_DTIMG=y
+CONFIG_CMD_ADTIMG=y
 CONFIG_CMD_BCB=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set
index f2cbf2fe2ba1361b7de456a75a5b17e321f91d32..87f391c2b02942054e3d25ae5a000344d1134faf 100644 (file)
@@ -37,7 +37,7 @@ CONFIG_SYS_SPI_U_BOOT_OFFS=0x40000
 CONFIG_SPL_USB_GADGET=y
 CONFIG_SPL_DFU=y
 CONFIG_SPL_YMODEM_SUPPORT=y
-CONFIG_CMD_DTIMG=y
+CONFIG_CMD_ADTIMG=y
 CONFIG_CMD_BCB=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_SETEXPR is not set