libbb: open_zipped() should not fail on non-compressed files

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

diff --git a/archival/libarchive/open_transformer.c b/archival/libarchive/open_transformer.c
index 1aeba13bc9eb6f1256ed4ab2660935ff0734b993..27854af21e36287ad941cbf9783becd5705e9937 100644 (file)
--- a/archival/libarchive/open_transformer.c
+++ b/archival/libarchive/open_transformer.c
@@ -200,7 +200,16 @@ int FAST_FUNC open_zipped(const char *fname)
         || (ENABLE_FEATURE_SEAMLESS_BZ2)
         || (ENABLE_FEATURE_SEAMLESS_XZ)
        ) {
-               setup_unzip_on_fd(fd, /*fail_if_not_detected:*/ 1);
+               /*
+                * Do we want to fail_if_not_detected?
+                * In most cases, no: think "insmod non_compressed_module".
+                * A case which would like to fail is "zcat uncompressed_file":
+                * otherwise, it happily outputs uncompressed_file as-is,
+                * which is, strictly speaking, not what is expected.
+                * If this ever becomes a problem, we can add
+                * fail_if_not_detected bool argument to open_zipped().
+                */
+               setup_unzip_on_fd(fd, /*fail_if_not_detected:*/ 0);
        }
 
        return fd;