dtscreen: Resolve (all) 11 warnigns caused by -Wall

diff --git a/cde/programs/dtscreen/dtscreen.c b/cde/programs/dtscreen/dtscreen.c
index 6c2278650d6543786815e9fa8a0736d09c597859..673c4d9a368fd5ef64d3e1739d14e785d6586ba1 100644 (file)
--- a/cde/programs/dtscreen/dtscreen.c
+++ b/cde/programs/dtscreen/dtscreen.c
@@ -112,6 +112,7 @@ nl_catd  scmc_catd;   /* Cat descriptor for scmc conversion */
 #include <stdlib.h>
 #include <signal.h>
 #include <string.h>
+#include <errno.h>
 
 #include <X11/Intrinsic.h> /* For Boolean */
 #include <X11/Shell.h>
@@ -219,7 +220,6 @@ main(argc, argv)
 {
     XSetWindowAttributes xswa;
     XGCValues   xgcv;
-    XColor      nullcolor;
     int         nitems = 0;
     int         window;
     int i;
@@ -375,7 +375,9 @@ main(argc, argv)
       Win[window].gc = XCreateGC(dsp, Win[window].w,
                          GCForeground | GCBackground, &xgcv);
     }
-    nice(nicelevel);
+    if(-1 == nice(nicelevel)) {
+      fprintf(stderr, "dtscreen: failed to set nice() level '%s'\n", strerror(errno));
+    }
 
     justDisplay();
 

diff --git a/cde/programs/dtscreen/dtscreen.h b/cde/programs/dtscreen/dtscreen.h
index 6bf8c8f0d074c85dcd333a2a4f88724392d4eccb..8e27aae48d6dbdf981fdc3bb906ad86925b4f698 100644 (file)
--- a/cde/programs/dtscreen/dtscreen.h
+++ b/cde/programs/dtscreen/dtscreen.h
@@ -41,6 +41,8 @@
 #include <X11/Xutil.h>
 #include <X11/Xos.h>
 
+#include <Dt/Dt.h>
+
 #define MAXSCREENS 3
 #define NUMCOLORS 64
 
@@ -74,6 +76,7 @@ extern void (*callback) ();
 extern void (*init) ();
 
 extern void GetResources();
+extern void CheckResources();
 extern void hsbramp();
 extern void error();
 extern long seconds();

diff --git a/cde/programs/dtscreen/flame.c b/cde/programs/dtscreen/flame.c
index 9ba56a50bf5704b22f0e0b0db7015c1bacee9086..e4cfbca1bb8bfd3ee269374b2885d07073eb3c92 100644 (file)
--- a/cde/programs/dtscreen/flame.c
+++ b/cde/programs/dtscreen/flame.c
@@ -119,7 +119,7 @@ recurse(fs, x, y, l)
     register double x, y;
     register int l;
 {
-    int         xp, yp, i;
+    int         i;
     double      nx, ny;
 
     if (l == fs->max_levels) {
@@ -128,10 +128,6 @@ recurse(fs, x, y, l)
            return False;
 
        if (x > -1.0 && x < 1.0 && y > -1.0 && y < 1.0) {
-           xp = fs->pts[fs->num_points].x = (int) ((fs->width / 2)
-                                                   * (x + 1.0));
-           yp = fs->pts[fs->num_points].y = (int) ((fs->height / 2)
-                                                   * (y + 1.0));
            fs->num_points++;
            if (fs->num_points > MAXBATCH) {    /* point buffer size */
                XDrawPoints(dsp, fs->pwin->w, fs->pwin->gc, fs->pts,
@@ -162,7 +158,7 @@ drawflame(pwin)
     flamestruct *fs = (flamestruct *)pwin->data;
 
     int         i, j, k;
-    static      alt = 0;
+    static int  alt = 0;
 
     if (!(fs->cur_level++ % fs->max_levels)) {
        XClearWindow(dsp, fs->pwin->w);

diff --git a/cde/programs/dtscreen/pyro.c b/cde/programs/dtscreen/pyro.c
index 0501f55fe421b518f2b7364e7ed952a5e5fa2c59..e485a25f392e9d4c78805d8210eb7dec42f5342d 100644 (file)
--- a/cde/programs/dtscreen/pyro.c
+++ b/cde/programs/dtscreen/pyro.c
@@ -250,7 +250,7 @@ ignite(pwin, pp)
     x = random() % pp->width;
     xvel = FLOATRAND(-pp->maxvelx, pp->maxvelx);
 /* All this to stop too many rockets going offscreen: */
-    if (x < pp->lmargin && xvel < 0.0 || x > pp->rmargin && xvel > 0.0)
+    if ((x < pp->lmargin && xvel < 0.0) || (x > pp->rmargin && xvel > 0.0))
        xvel = -xvel;
     yvel = FLOATRAND(pp->minvely, pp->maxvely);
     fuse = INTRAND(MINFUSE, MAXFUSE);

diff --git a/cde/programs/dtscreen/resource.c b/cde/programs/dtscreen/resource.c
index 060a62e8454165b4389d3b0e58082bede54c168b..685207bd1b648a605f5ffebd19a8bcb07a2021f6 100644 (file)
--- a/cde/programs/dtscreen/resource.c
+++ b/cde/programs/dtscreen/resource.c
@@ -101,6 +101,8 @@ extern void drawflame();
 extern void initworm();
 extern void drawworm();
 
+void CheckResources(void);
+
 typedef struct {
     char       *cmdline_arg;
     void        (*lp_init) ();
@@ -507,7 +509,6 @@ open_display()
 {
     if (display != NULL) {
        char       *colon = strchr(display, ':');
-       int         n = colon - display;
 
        if (colon == NULL)
 #ifdef MIT_R5
@@ -710,7 +711,7 @@ GetResources(argc, argv)
 }
 
 
-CheckResources()
+void CheckResources(void)
 {
     int         i;
 

diff --git a/cde/programs/dtscreen/rotor.c b/cde/programs/dtscreen/rotor.c
index ead68a8e710a439c0827265f10391798b2cf7648..99ef77560ee61630127b03792bfb0c7e7fd0c3b4 100644 (file)
--- a/cde/programs/dtscreen/rotor.c
+++ b/cde/programs/dtscreen/rotor.c
@@ -56,7 +56,7 @@
 #define MAXANGLE       10000.0 /* irrectangular */
 #define DEFAULTCOUNT   3
 
-typedef unsigned char Boolean;
+/*typedef unsigned char Boolean; */
 
 #define IDENT(X)       X
 #if defined (__STDC__) || defined (AIXV3)