util/mkerr.pl: Add an inclusion of symhacks.h in all error files

This does no harm, and ensures that the inclusion isn't mistakenly
removed in the generated *err.h where it's actually needed.

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8397)

diff --git a/include/openssl/cryptoerr.h b/include/openssl/cryptoerr.h
index 2f3df746d2cc83dda912b4811ed8bbdc25bfcf29..e757b0e1508a9e26bbef1cd40ce0c76bb6049fe1 100644 (file)
--- a/include/openssl/cryptoerr.h
+++ b/include/openssl/cryptoerr.h
@@ -15,8 +15,6 @@
 extern "C"
 # endif
 
-# include <openssl/symhacks.h>
-
 int ERR_load_CRYPTO_strings(void);
 
 /*

diff --git a/util/mkerr.pl b/util/mkerr.pl
index cf100d121022d98581b49da23e62486b99e5eea1..7139ee3bea07a68d323f251d98e51d57f97248af 100755 (executable)
--- a/util/mkerr.pl
+++ b/util/mkerr.pl
@@ -417,9 +417,7 @@ print STDERR "\n" if $debug;
 &phase("Writing files");
 my $newstate = 0;
 foreach my $lib ( keys %errorfile ) {
-    if ( ! $fnew{$lib} && ! $rnew{$lib} ) {
-        next unless $rebuild;
-    }
+    next if ! $fnew{$lib} && ! $rnew{$lib} && ! $rebuild;
     next if scalar keys %modules > 0 && !$modules{$lib};
     next if $nowrite;
     print STDERR "$lib: $fnew{$lib} new functions\n" if $fnew{$lib};
@@ -455,6 +453,10 @@ foreach my $lib ( keys %errorfile ) {
 #ifndef HEADER_${lib}ERR_H
 # define HEADER_${lib}ERR_H
 
+# ifndef HEADER_SYMHACKS_H
+#  include <openssl/symhacks.h>
+# endif
+
 EOF
     if ( $internal ) {
         # Declare the load function because the generate C file