clk: zynqmp: Fixed the same if/else part error reported by coverity
authorVipul Kumar <vipul.kumar@xilinx.com>
Wed, 27 Jun 2018 05:14:45 +0000 (10:44 +0530)
committerMichal Simek <michal.simek@xilinx.com>
Thu, 19 Jul 2018 08:49:53 +0000 (10:49 +0200)
This patch fixed the same if/else part error by adding the required
source select on the basis of is_pre_src check.

Signed-off-by: Vipul Kumar <vipul.kumar@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/clk/clk_zynqmp.c

index a9e45007054036a1bed0f502a029958d10e11d3b..167f3f75a19cf6a593a97093e358a151bc83ef21 100644 (file)
@@ -103,6 +103,8 @@ static const resource_size_t zynqmp_crl_apb_clkc_base = 0xff5e0020;
 #define PLLCTRL_BYPASS_SHFT    3
 #define PLLCTRL_POST_SRC_SHFT  24
 #define PLLCTRL_POST_SRC_MASK  (0x7 << PLLCTRL_POST_SRC_SHFT)
+#define PLLCTRL_PRE_SRC_SHFT   20
+#define PLLCTRL_PRE_SRC_MASK   (0x7 << PLLCTRL_PRE_SRC_SHFT)
 
 
 #define NUM_MIO_PINS   77
@@ -310,8 +312,8 @@ static ulong zynqmp_clk_get_pll_src(ulong clk_ctrl,
        u32 src_sel;
 
        if (is_pre_src)
-               src_sel = (clk_ctrl & PLLCTRL_POST_SRC_MASK) >>
-                          PLLCTRL_POST_SRC_SHFT;
+               src_sel = (clk_ctrl & PLLCTRL_PRE_SRC_MASK) >>
+                          PLLCTRL_PRE_SRC_SHFT;
        else
                src_sel = (clk_ctrl & PLLCTRL_POST_SRC_MASK) >>
                           PLLCTRL_POST_SRC_SHFT;