projects
/
oweals
/
tinc.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
de7d9ee
)
Fix undefined behaviour when left-shifting signed integers.
author
Guus Sliepen
<guus@tinc-vpn.org>
Sun, 12 Jul 2015 10:33:07 +0000
(12:33 +0200)
committer
Guus Sliepen
<guus@tinc-vpn.org>
Sun, 12 Jul 2015 10:33:07 +0000
(12:33 +0200)
Found by -fsanitize=undefined.
src/hash.c
patch
|
blob
|
history
diff --git
a/src/hash.c
b/src/hash.c
index 91fc3d6754341c0d738b802ce925cb7522268991..50934d9b99dc53c01fe4a220f6cf3ab304a58e53 100644
(file)
--- a/
src/hash.c
+++ b/
src/hash.c
@@
-29,7
+29,7
@@
static uint32_t hash_function(const void *p, size_t len) {
uint32_t hash = 0;
while(true) {
for(int i = len > 4 ? 4 : len; --i;)
- hash += q[len - i] << (8 * i);
+ hash +=
(uint32_t)
q[len - i] << (8 * i);
hash *= 0x9e370001UL; // Golden ratio prime.
if(len <= 4)
break;