rockchip: xhci: remove DTS parsing for PHY (which is unused)
authorPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Thu, 24 May 2018 15:11:57 +0000 (17:11 +0200)
committerMarek Vasut <marex@denx.de>
Wed, 30 May 2018 09:59:10 +0000 (11:59 +0200)
The xhci wrapper-driver for Rockchip searches the DTS to find its
child node compatbile with 'rockchip,rk3399-usb3-phy' to retrieve the
base-address of the PHY.  However, this is currently broken (and
always has been), returning NULL.  However, the (wrongly) retrieved
base-address is never used.

We thus remove this code for now.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
drivers/usb/host/xhci-rockchip.c

index 060a6c43092f441f37322c220ba1d6ae45b4b55f..f19bea3a91b736d1ad2e9434aa6192c78494b77a 100644 (file)
@@ -17,7 +17,6 @@
 
 struct rockchip_xhci_platdata {
        fdt_addr_t hcd_base;
-       fdt_addr_t phy_base;
        struct udevice *vbus_supply;
 };
 
@@ -35,7 +34,6 @@ struct rockchip_xhci {
 static int xhci_usb_ofdata_to_platdata(struct udevice *dev)
 {
        struct rockchip_xhci_platdata *plat = dev_get_platdata(dev);
-       struct udevice *child;
        int ret = 0;
 
        /*
@@ -47,20 +45,6 @@ static int xhci_usb_ofdata_to_platdata(struct udevice *dev)
                return -ENXIO;
        }
 
-       /* Get the base address for usbphy from the device node */
-       for (device_find_first_child(dev, &child); child;
-            device_find_next_child(&child)) {
-               if (!device_is_compatible(child, "rockchip,rk3399-usb3-phy"))
-                       continue;
-               plat->phy_base = devfdt_get_addr(child);
-               break;
-       }
-
-       if (plat->phy_base == FDT_ADDR_T_NONE) {
-               pr_err("Can't get the usbphy register address\n");
-               return -ENXIO;
-       }
-
        /* Vbus regulator */
        ret = device_get_supply_regulator(dev, "vbus-supply",
                                          &plat->vbus_supply);