- check minimum size, param order

diff --git a/src/cadet/cadet_api.c b/src/cadet/cadet_api.c
index 43fe3535f35bda05e3221b0e3fac77d6aaa75793..f0d01d8aadac958b0af2b7c72e0bea2a50b0a238 100644 (file)
--- a/src/cadet/cadet_api.c
+++ b/src/cadet/cadet_api.c
@@ -1357,6 +1357,7 @@ send_callback (void *cls, size_t size, void *buf)
       {
         psize += sizeof (struct GNUNET_CADET_LocalData);
         GNUNET_assert (size >= psize);
+        GNUNET_assert (sizeof (struct GNUNET_MessageHeader) <= psize);
         dmsg->header.size = htons (psize);
         dmsg->id = htonl (ch->chid);
         dmsg->header.type = htons (GNUNET_MESSAGE_TYPE_CADET_LOCAL_DATA);

diff --git a/src/cadet/gnunet-service-cadet_local.c b/src/cadet/gnunet-service-cadet_local.c
index 5eb17a55f8efba96065aa1b5874fcfa55cfb6eeb..5fe160bdc2bb1ed02536037da36f20d6ccaa6e30 100644 (file)
--- a/src/cadet/gnunet-service-cadet_local.c
+++ b/src/cadet/gnunet-service-cadet_local.c
@@ -493,7 +493,7 @@ handle_data (void *cls, struct GNUNET_SERVER_Client *client,
 
   /* Sanity check for message size */
   size = ntohs (message->size) - sizeof (struct GNUNET_CADET_LocalData);
-  if (size < sizeof (struct GNUNET_MessageHeader))
+  if (sizeof (struct GNUNET_MessageHeader) > size)
   {
     GNUNET_break (0);
     GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);