sunxi: board: Print error after power initialization fails
authorOlliver Schinagl <oliver@schinagl.nl>
Wed, 21 Nov 2018 18:05:25 +0000 (20:05 +0200)
committerJagan Teki <jagan@amarulasolutions.com>
Fri, 7 Dec 2018 16:54:33 +0000 (22:24 +0530)
Currently during init, we enable all power, then enable the dram and
after that check whether there was an error during power-up.

This makes little sense, we should enable power and then check if power
was brought up properly before we continue to initialize other things.

This patch moves the DRAM init after the power failure check.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Signed-off-by: Priit Laes <plaes@plaes.org>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
board/sunxi/board.c

index 64ccbc7245f5746079d1b1c458d720c1d10e132f..26284db1112bf1b176d350b53acd77375067b1d5 100644 (file)
@@ -637,13 +637,6 @@ void sunxi_board_init(void)
        power_failed |= axp_set_sw(IS_ENABLED(CONFIG_AXP_SW_ON));
 #endif
 #endif
-       printf("DRAM:");
-       gd->ram_size = sunxi_dram_init();
-       printf(" %d MiB\n", (int)(gd->ram_size >> 20));
-       if (!gd->ram_size)
-               hang();
-
-       sunxi_spl_store_dram_size(gd->ram_size);
 
        /*
         * Only clock up the CPU to full speed if we are reasonably
@@ -652,7 +645,16 @@ void sunxi_board_init(void)
        if (!power_failed)
                clock_set_pll1(CONFIG_SYS_CLK_FREQ);
        else
-               printf("Failed to set core voltage! Can't set CPU frequency\n");
+               printf("Error setting up the power controller.\n"
+                      "CPU frequency not set.\n");
+
+       printf("DRAM:");
+       gd->ram_size = sunxi_dram_init();
+       printf(" %d MiB\n", (int)(gd->ram_size >> 20));
+       if (!gd->ram_size)
+               hang();
+
+       sunxi_spl_store_dram_size(gd->ram_size);
 }
 #endif