esdhc: memset mmc struct before putting into use
authorHaijun.Zhang <Haijun.Zhang@freescale.com>
Thu, 31 Oct 2013 01:38:18 +0000 (09:38 +0800)
committerPantelis Antoniou <panto@antoniou-consulting.com>
Thu, 31 Oct 2013 07:55:34 +0000 (09:55 +0200)
struct mmc should be clear to all '0' after malloc to avoid
unexpect variable value.

Like mmc->has_init = xxx.
In this case mmcinfo will believe the card had been initialized before
and skip the initialization.

Test on P5040 and T4240,
Error Log:

=> mmcinfo
Device: FSL_SDHC
Manufacturer ID: 0
OEM: 0
Name: Tran Speed: 0
Rd Block Len: 0
MMC version 0.0
High Capacity: No
Capacity: 0 Bytes
Bus Width: 0-bit
=>

Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
Signed-off-by: Xie Shaohui-B21989 <B21989@freescale.com>
Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>
drivers/mmc/fsl_esdhc.c

index a9fe911c8b313340a5a049ac1025464d403999f4..1f9c305131b4284b1585e0ac0d121d501fdac0e4 100644 (file)
@@ -533,6 +533,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
        if (!mmc)
                return -ENOMEM;
 
+       memset(mmc, 0, sizeof(struct mmc));
        sprintf(mmc->name, "FSL_SDHC");
        regs = (struct fsl_esdhc *)cfg->esdhc_base;