Rewrite timeout computation in a way that is less prone to overflow.

(Problem reported by Peter Sylvester.)

diff --git a/ssl/ssl_sess.c b/ssl/ssl_sess.c
index da6b023c363fde958861ddf8f88dbfa28ef470af..2f26593c70087ed1afd9afd41f391c54a40cf4c8 100644 (file)
--- a/ssl/ssl_sess.c
+++ b/ssl/ssl_sess.c
@@ -389,7 +389,7 @@ int ssl_get_prev_session(SSL *s, unsigned char *session_id, int len)
        CRYPTO_add(&ret->references,1,CRYPTO_LOCK_SSL_SESSION);
 #endif
 
-       if ((long)(ret->time+ret->timeout) < (long)time(NULL)) /* timeout */
+       if (ret->timeout < (long)(time(NULL) - ret->time)) /* timeout */
                {
                s->ctx->stats.sess_timeout++;
                /* remove it from the cache */