projects
/
oweals
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2b80b4e
)
video: test: Adjust order of file closure
author
Simon Glass
<sjg@chromium.org>
Sat, 30 Jan 2016 22:45:17 +0000
(15:45 -0700)
committer
Anatolij Gustschin
<agust@denx.de>
Sat, 6 Feb 2016 12:57:15 +0000
(13:57 +0100)
Close the file earlier to hopefully fix a Coverity error.
Reported-by: Coverity (CID: 134901)
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
test/dm/video.c
patch
|
blob
|
history
diff --git
a/test/dm/video.c
b/test/dm/video.c
index de223281b45c8480c9e20379bf21ed86f540cf4d..4d000fa1bea5b41681b763b0dd318dd52d6f4afd 100644
(file)
--- a/
test/dm/video.c
+++ b/
test/dm/video.c
@@
-249,9
+249,9
@@
static int read_file(struct unit_test_state *uts, const char *fname,
fd = os_open(fname, OS_O_RDONLY);
ut_assert(fd >= 0);
size = os_read(fd, buf, buf_size);
+ os_close(fd);
ut_assert(size >= 0);
ut_assert(size < buf_size);
- os_close(fd);
*addrp = addr;
return 0;