RT2914: NULL check missing in X509_name_canon
authorRich Salz <rsalz@openssl.org>
Sun, 4 Jan 2015 19:51:04 +0000 (14:51 -0500)
committerRich Salz <rsalz@openssl.org>
Sun, 4 Jan 2015 19:52:16 +0000 (14:52 -0500)
Check for NULL return from X509_NAME_ENTRY_new()

Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
(cherry picked from commit 2c60925d1ccc0b96287bdc9acb90198e7180d642)

crypto/asn1/x_name.c

index d7c2318693f5aab79ba34885aeee1987e251d117..22da57040e89a7ce83efa218a7558d6da9cc30c1 100644 (file)
@@ -350,6 +350,8 @@ static int x509_name_canon(X509_NAME *a)
                        set = entry->set;
                        }
                tmpentry = X509_NAME_ENTRY_new();
+               if (!tmpentry)
+                       goto err;
                tmpentry->object = OBJ_dup(entry->object);
                if (!asn1_string_canon(tmpentry->value, entry->value))
                        goto err;