Fix memory leak in protocol 38 set_sky
authorsfan5 <sfan5@live.de>
Thu, 5 Mar 2020 21:36:21 +0000 (22:36 +0100)
committerGitHub <noreply@github.com>
Thu, 5 Mar 2020 21:36:21 +0000 (22:36 +0100)
src/network/clientpackethandler.cpp

index f6de9cd8bcab9fa5c8e098cf2c24da467d1be416..0a9f8c212b9dc9662dd0af41a3c5cce5ae4485c4 100644 (file)
@@ -1244,12 +1244,11 @@ void Client::handleCommand_HudSetSky(NetworkPacket* pkt)
                skybox.bgcolor = video::SColor(readARGB8(is));
                skybox.type = std::string(deSerializeString(is));
                u16 count = readU16(is);
-               std::vector<std::string>* params = new std::vector<std::string>;
 
                for (size_t i = 0; i < count; i++)
                        skybox.textures.emplace_back(deSerializeString(is));
 
-               bool clouds = true;
+               skybox.clouds = true;
                try {
                        skybox.clouds = readU8(is);
                } catch (...) {}