dm: usb: Unbind old block devices when shutting down USB
authorSimon Glass <sjg@chromium.org>
Sun, 13 Mar 2016 14:22:33 +0000 (08:22 -0600)
committerSimon Glass <sjg@chromium.org>
Fri, 18 Mar 2016 03:27:39 +0000 (21:27 -0600)
When 'usb start' is used, block devices are created for any USB flash sticks
and disks, etc. When 'usb stop' is used, these block devices are currently
not removed.

We don't want old block devices hanging around since they can still be
visible to U-Boot. Therefore, when USB is shut down, remove and unbind all
the block devices created by the USB subsystem.

Possibly we should unbind all devices which don't cause problems by being
unbound. Most likely we can remove everything except USB controllers, hubs
and emulators. We can consider that later.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Stephen Warren <swarren@nvidia.com>
drivers/usb/host/usb-uclass.c

index 50538e0bd760461342812df0a162d262e541e0a4..69c9a504ebb8ad8489523868b8991d871115c3d4 100644 (file)
@@ -159,7 +159,11 @@ int usb_stop(void)
                if (ret && !err)
                        err = ret;
        }
-
+#ifdef CONFIG_BLK
+       ret = blk_unbind_all(IF_TYPE_USB);
+       if (ret && !err)
+               err = ret;
+#endif
 #ifdef CONFIG_SANDBOX
        struct udevice *dev;