sf: stmicro: drop redundant id read
authorMike Frysinger <vapier@gentoo.org>
Fri, 27 Mar 2009 20:34:21 +0000 (16:34 -0400)
committerMike Frysinger <vapier@gentoo.org>
Thu, 2 Apr 2009 10:50:17 +0000 (06:50 -0400)
The common SPI flash code reads the idcode and passes it down to the SPI
flash driver, so there is no need to read it again ourselves.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
CC: Jason McMullan <mcmullan@netapp.com>
CC: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
drivers/mtd/spi/stmicro.c

index e7dda91a407788093ef7d216e99f4a825a8f4c98..e401cd07bc3c2355d7f3580906dc45ba8e061d66 100644 (file)
@@ -315,12 +315,6 @@ struct spi_flash *spi_flash_probe_stmicro(struct spi_slave *spi, u8 * idcode)
        const struct stmicro_spi_flash_params *params;
        struct stmicro_spi_flash *stm;
        unsigned int i;
-       int ret;
-       u8 id[3];
-
-       ret = spi_flash_cmd(spi, CMD_READ_ID, id, sizeof(id));
-       if (ret)
-               return NULL;
 
        for (i = 0; i < ARRAY_SIZE(stmicro_spi_flash_table); i++) {
                params = &stmicro_spi_flash_table[i];
@@ -330,7 +324,7 @@ struct spi_flash *spi_flash_probe_stmicro(struct spi_slave *spi, u8 * idcode)
        }
 
        if (i == ARRAY_SIZE(stmicro_spi_flash_table)) {
-               debug("SF: Unsupported STMicro ID %02x\n", id[1]);
+               debug("SF: Unsupported STMicro ID %02x\n", idcode[1]);
                return NULL;
        }