makedevs: make it NOEXEC

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst
index fb76fcf63e025118db3da651569ba970988d2c6a..63ec08643c3e6cc4ecc5a6e339db75aff22e6649 100644 (file)
--- a/NOFORK_NOEXEC.lst
+++ b/NOFORK_NOEXEC.lst
@@ -127,7 +127,7 @@ findfs - suid
 flash_eraseall
 flash_lock
 flash_unlock
-flashcp - needs ^C. flash writing may be slow, better to free memory memory by execing
+flashcp - needs ^C. flash writing may be slow, better to free memory by execing
 flock - spawner, changes state (file locks), let's play safe and not be noexec
 fold - noexec. runner
 free - nofork candidate(struct globals, needs to close /proc/meminfo fd)
@@ -214,7 +214,7 @@ lzcat - runner
 lzma - runner
 lzop - runner
 lzopcat - runner
-makedevs
+makedevs - noexec
 makemime - runner
 man - spawner, interactive, longterm
 md5sum - noexec. runner
@@ -278,7 +278,7 @@ raidautorun - noexec. very simple. leaks: open+xioctl
 rdate - needs ^C (may talk to DNS servers, which may be down)
 rdev - leaks: find_block_device -> readdir+xstrdup
 readlink - NOFORK
-readprofile - reads /boot/System.map and /proc/profile, better to free more memory memory by execing?
+readprofile - reads /boot/System.map and /proc/profile, better to free more memory by execing?
 realpath - NOFORK
 reboot - rare
 reformime - runner

diff --git a/miscutils/makedevs.c b/miscutils/makedevs.c
index c2f86df01f19856e8abb15f6f1989cf3485d89bd..c13ad1442fa6bae56916b3070816f067b5b16264 100644 (file)
--- a/miscutils/makedevs.c
+++ b/miscutils/makedevs.c
@@ -38,7 +38,7 @@
 //config:
 //config:endchoice
 
-//applet:IF_MAKEDEVS(APPLET(makedevs, BB_DIR_SBIN, BB_SUID_DROP))
+//applet:IF_MAKEDEVS(APPLET_NOEXEC(makedevs, makedevs, BB_DIR_SBIN, BB_SUID_DROP, makedevs))
 
 //kbuild:lib-$(CONFIG_MAKEDEVS) += makedevs.o