expand,unexpand: drop broken test, add FIXME comment
authorDenys Vlasenko <vda.linux@googlemail.com>
Sat, 8 Jun 2019 11:04:44 +0000 (13:04 +0200)
committerDenys Vlasenko <vda.linux@googlemail.com>
Sat, 8 Jun 2019 11:04:44 +0000 (13:04 +0200)
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
coreutils/expand.c
testsuite/expand/expand-works-like-GNU [deleted file]
testsuite/unexpand/unexpand-works-like-GNU [deleted file]

index f7e4619f9b475112b5a79a4ae0a9780f7e5ee1e5..8d064db5e1bc8f2c16c7f59b23299879dfb25fda 100644 (file)
@@ -63,6 +63,8 @@ enum {
        OPT_ALL         = 1 << 2,
 };
 
+//FIXME: does not work properly with input containing NULs
+
 #if ENABLE_EXPAND
 static void expand(FILE *file, unsigned tab_size, unsigned opt)
 {
diff --git a/testsuite/expand/expand-works-like-GNU b/testsuite/expand/expand-works-like-GNU
deleted file mode 100644 (file)
index b0278d8..0000000
+++ /dev/null
@@ -1,20 +0,0 @@
-# FEATURE: CONFIG_UNEXPAND
-
-rm -f foo bar
-$ECHO -e "\ty" | expand -t 3 ../../busybox > foo
-$ECHO -e "\ty" | busybox unexpand -t 3 ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-rm -f foo bar
-$ECHO -e "\ty\tx" | expand -it 3 ../../busybox > foo
-$ECHO -e "\ty\tx" | busybox unexpand -it 3 ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
diff --git a/testsuite/unexpand/unexpand-works-like-GNU b/testsuite/unexpand/unexpand-works-like-GNU
deleted file mode 100644 (file)
index 111b277..0000000
+++ /dev/null
@@ -1,56 +0,0 @@
-# coreutils 8.25 often says "input line is too long"
-# on ELF executables. In this case, do not run the test:
-unexpand ../../busybox >/dev/null || exit 0
-
-rm -f foo bar
-echo "       y" | unexpand ../../busybox > foo
-echo "       y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-rm -f foo bar
-echo "        y" | unexpand ../../busybox > foo
-echo "        y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-echo "       y       y" | unexpand ../../busybox > foo
-echo "       y       y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-rm -f foo bar
-echo "        y        y" | unexpand ../../busybox > foo
-echo "        y        y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-echo "       y       y" | unexpand -a ../../busybox > foo
-echo "       y       y" | busybox unexpand -a ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi
-rm -f foo bar
-echo "        y        y" | unexpand -a ../../busybox > foo
-echo "        y        y" | busybox unexpand -a ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-       set -e
-       diff -q foo bar
-fi