Makes SCT_LIST_set_source return the number of successes

No longer terminates on first error, but instead tries to set the source
of every SCT regardless of whether an error occurs with some.

Reviewed-by: Emilia Käsper <emilia@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>

diff --git a/crypto/ct/ct_sct.c b/crypto/ct/ct_sct.c
index 2b7211d7ea42f42cb34e00c649bddc7753839fe6..8290945e513298dd08d83dc38db5a22a5a1091c1 100644 (file)
--- a/crypto/ct/ct_sct.c
+++ b/crypto/ct/ct_sct.c
@@ -317,12 +317,11 @@ int SCT_set_source(SCT *sct, sct_source_t source)
 
 int SCT_LIST_set_source(const STACK_OF(SCT) *scts, sct_source_t source)
 {
-    int i, ret = 1;
+    int i, ret = 0;
 
     for (i = 0; i < sk_SCT_num(scts); ++i) {
-        ret = SCT_set_source(sk_SCT_value(scts, i), source);
-        if (ret != 1)
-            break;
+        if (SCT_set_source(sk_SCT_value(scts, i), source))
+            ++ret;
     }
 
     return ret;

diff --git a/include/openssl/ct.h b/include/openssl/ct.h
index 6d2182f796f154c5f3de7a822aa25d4809d41272..7a19053018c4f4011a6f6393b1b9cfa2a8ca2303 100644 (file)
--- a/include/openssl/ct.h
+++ b/include/openssl/ct.h
@@ -305,7 +305,7 @@ int SCT_set_source(SCT *sct, sct_source_t source);
 
 /*
  * Sets the source of all of the SCTs to the same value.
- * Returns 1 on success.
+ * Returns the number of SCTs whose source was set successfully.
  */
 int SCT_LIST_set_source(const STACK_OF(SCT) *scts, sct_source_t source);