image-sig: use designated initializers for algorithm
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Mon, 23 Oct 2017 01:03:40 +0000 (10:03 +0900)
committerTom Rini <trini@konsulko.com>
Mon, 6 Nov 2017 14:58:59 +0000 (09:58 -0500)
Designated initializers are more readable because we do not
have to check the order in the struct definitions.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/image-sig.c

index 455f2b96294985af5fb7fb9011bb45e2bc8b33b3..bf824fef3c71bf4fa2b4f66aaed89ff17a021e43 100644 (file)
@@ -32,42 +32,42 @@ void *image_get_host_blob(void)
 
 struct checksum_algo checksum_algos[] = {
        {
-               "sha1",
-               SHA1_SUM_LEN,
-               SHA1_DER_LEN,
-               sha1_der_prefix,
+               .name = "sha1",
+               .checksum_len = SHA1_SUM_LEN,
+               .der_len = SHA1_DER_LEN,
+               .der_prefix = sha1_der_prefix,
 #if IMAGE_ENABLE_SIGN
-               EVP_sha1,
+               .calculate_sign = EVP_sha1,
 #endif
-               hash_calculate,
+               .calculate = hash_calculate,
        },
        {
-               "sha256",
-               SHA256_SUM_LEN,
-               SHA256_DER_LEN,
-               sha256_der_prefix,
+               .name = "sha256",
+               .checksum_len = SHA256_SUM_LEN,
+               .der_len = SHA256_DER_LEN,
+               .der_prefix = sha256_der_prefix,
 #if IMAGE_ENABLE_SIGN
-               EVP_sha256,
+               .calculate_sign = EVP_sha256,
 #endif
-               hash_calculate,
+               .calculate = hash_calculate,
        }
 
 };
 
 struct crypto_algo crypto_algos[] = {
        {
-               "rsa2048",
-               RSA2048_BYTES,
-               rsa_sign,
-               rsa_add_verify_data,
-               rsa_verify,
+               .name = "rsa2048",
+               .key_len = RSA2048_BYTES,
+               .sign = rsa_sign,
+               .add_verify_data = rsa_add_verify_data,
+               .verify = rsa_verify,
        },
        {
-               "rsa4096",
-               RSA4096_BYTES,
-               rsa_sign,
-               rsa_add_verify_data,
-               rsa_verify,
+               .name = "rsa4096",
+               .key_len = RSA4096_BYTES,
+               .sign = rsa_sign,
+               .add_verify_data = rsa_add_verify_data,
+               .verify = rsa_verify,
        }
 
 };