cmd_sf: Fix compiler warning
authorKumar Gala <galak@kernel.crashing.org>
Mon, 3 Oct 2011 04:35:47 +0000 (04:35 +0000)
committerWolfgang Denk <wd@denx.de>
Wed, 5 Oct 2011 20:22:17 +0000 (22:22 +0200)
cmd_sf.c: In function 'do_spi_flash':
cmd_sf.c:164:9: warning: 'skipped' may be used uninitialized in this function

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Simon Glass <sjg@chromium.org>
common/cmd_sf.c

index c8c547ac0b71ed3a6d41c1a71d5aac0883016345..72256567d32089a154b7c58edb3fda9e61acd486 100644 (file)
@@ -161,12 +161,11 @@ static int spi_flash_update(struct spi_flash *flash, u32 offset,
        char *cmp_buf;
        const char *end = buf + len;
        size_t todo;            /* number of bytes to do in this pass */
-       size_t skipped;         /* statistics */
+       size_t skipped = 0;     /* statistics */
 
        cmp_buf = malloc(flash->sector_size);
        if (cmp_buf) {
-               for (skipped = 0; buf < end && !err_oper;
-                               buf += todo, offset += todo) {
+               for (; buf < end && !err_oper; buf += todo, offset += todo) {
                        todo = min(end - buf, flash->sector_size);
                        err_oper = spi_flash_update_block(flash, offset, todo,
                                        buf, cmp_buf, &skipped);
@@ -181,6 +180,7 @@ static int spi_flash_update(struct spi_flash *flash, u32 offset,
        }
        printf("%zu bytes written, %zu bytes skipped\n", len - skipped,
               skipped);
+
        return 0;
 }