buildman: don't fail --list-toolchains when toolchains fail
authorStephen Warren <swarren@nvidia.com>
Wed, 9 Oct 2013 20:28:09 +0000 (14:28 -0600)
committerSimon Glass <sjg@chromium.org>
Thu, 10 Oct 2013 16:40:42 +0000 (10:40 -0600)
When a toolchain invocation fails, an exception is thrown but not caught
which then aborts the entire toolchain detection process. To solve this,
request that exceptions not be thrown, since the toolchain init code
already error-checks the command result. This solves e.g.:

         - found '/usr/bin/winegcc'
Traceback (most recent call last):
...
Exception: Error running '/usr/bin/winegcc --version'

Change-Id: I579c72ab3b021e38b14132893c3375ea257c74f0
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Simon Glass <sjg@chromium.org>
(formatted to 80cols)

tools/buildman/toolchain.py

index a292338b6d0894bd4cd5ca78154bd3c4c9b77b66..b64338680e9f3a0da02671779f9f9f11e37e169d 100644 (file)
@@ -39,7 +39,8 @@ class Toolchain:
         # As a basic sanity check, run the C compiler with --version
         cmd = [fname, '--version']
         if test:
-            result = command.RunPipe([cmd], capture=True, env=env)
+            result = command.RunPipe([cmd], capture=True, env=env,
+                                     raise_on_error=False)
             self.ok = result.return_code == 0
             if verbose:
                 print 'Tool chain test: ',