usb:ci_udc: Remove ULPI setting for i.MX OTG controller
authorYe.Li <B37916@freescale.com>
Thu, 31 Dec 2015 07:24:45 +0000 (15:24 +0800)
committerMarek Vasut <marex@denx.de>
Sat, 16 Jan 2016 06:06:55 +0000 (07:06 +0100)
All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI
interface. Set to ULPI is not correct, even the controller will
reject this setting in PORTSC register.

Signed-off-by: Ye.Li <B37916@freescale.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/usb/gadget/ci_udc.c

index 1ba5054965f05d9a9a2281b2a1bcc97ce1a79224..d36bcf64675314b84461567915d03e480213750d 100644 (file)
@@ -1018,18 +1018,10 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
                return ret;
 
        ret = ci_udc_probe();
-#if defined(CONFIG_USB_EHCI_MX6) || defined(CONFIG_USB_EHCI_MXS)
-       /*
-        * FIXME: usb_lowlevel_init()->ehci_hcd_init() should be doing all
-        * HW-specific initialization, e.g. ULPI-vs-UTMI PHY selection
-        */
-       if (!ret) {
-               struct ci_udc *udc = (struct ci_udc *)controller.ctrl->hcor;
-
-               /* select ULPI phy */
-               writel(PTS(PTS_ENABLE) | PFSC, &udc->portsc);
+       if (ret) {
+               DBG("udc probe failed, returned %d\n", ret);
+               return ret;
        }
-#endif
 
        ret = driver->bind(&controller.gadget);
        if (ret) {