make_directory used mode as if it were an signed entity, but in fact

it was a mode_t which is unsigned.  Fix it to be signed...
 -Erik

diff --git a/include/libbb.h b/include/libbb.h
index df52027ce0d8be0aee9ccf9e85b1dec7f1f0f211..70ac36a86174a45fe31fe066b8759498b003dcd3 100644 (file)
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -259,7 +259,7 @@ extern int create_icmp_socket(void);
 
 char *dirname (const char *path);
 
-int make_directory (char *path, mode_t mode, int flags);
+int make_directory (char *path, long mode, int flags);
 
 const char *u_signal_names(const char *str_sig, int *signo, int startnum);
 

diff --git a/libbb/libbb.h b/libbb/libbb.h
index df52027ce0d8be0aee9ccf9e85b1dec7f1f0f211..70ac36a86174a45fe31fe066b8759498b003dcd3 100644 (file)
--- a/libbb/libbb.h
+++ b/libbb/libbb.h
@@ -259,7 +259,7 @@ extern int create_icmp_socket(void);
 
 char *dirname (const char *path);
 
-int make_directory (char *path, mode_t mode, int flags);
+int make_directory (char *path, long mode, int flags);
 
 const char *u_signal_names(const char *str_sig, int *signo, int startnum);
 

diff --git a/libbb/make_directory.c b/libbb/make_directory.c
index 54d9b4c510fb6e35aaf6827aba608683851c49b9..0a9d7b16099b9c1a85fb55014122f82cc9969774 100644 (file)
--- a/libbb/make_directory.c
+++ b/libbb/make_directory.c
@@ -33,7 +33,7 @@
  * Also create parent directories as necessary if flags contains
  * FILEUTILS_RECUR.  */
 
-int make_directory (char *path, mode_t mode, int flags)
+int make_directory (char *path, long mode, int flags)
 {
        if (!(flags & FILEUTILS_RECUR)) {
                if (mkdir (path, 0777) < 0) {