luci-mod-system: flash.js: disable mtdblock downloads on mtd-less systems
authorJo-Philipp Wich <jo@mein.io>
Wed, 25 Sep 2019 17:42:06 +0000 (19:42 +0200)
committerJo-Philipp Wich <jo@mein.io>
Wed, 25 Sep 2019 17:42:06 +0000 (19:42 +0200)
Ref: https://github.com/openwrt/luci/commit/3c40a7450a9b7d340cdc9e233818c63a8092fec2#commitcomment-35233073
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
modules/luci-mod-system/htdocs/luci-static/resources/view/system/flash.js

index bea587625d81ca4a9d25a8eb93b4043c5978fae7..08c97650ea5b7ab1b23531ceabc1e3c89bcfca19 100644 (file)
@@ -508,20 +508,22 @@ return L.view.extend({
                o.onclick = L.bind(this.handleRestore, this);
 
 
-               o = s.option(form.SectionValue, 'actions', form.NamedSection, 'actions', 'actions', _('Save mtdblock contents'), _('Click "Save mtdblock" to download specified mtdblock file. (NOTE: THIS FEATURE IS FOR PROFESSIONALS! )'));
-               ss = o.subsection;
-
-               o = ss.option(form.ListValue, 'mtdselect', _('Choose mtdblock'));
-               procmtd.split(/\n/).forEach(function(ln) {
-                       var match = ln.match(/^mtd(\d+): .+ "(.+?)"$/);
-                       if (match)
-                               o.value(match[1], match[2]);
-               });
+               if (procmtd.length) {
+                       o = s.option(form.SectionValue, 'actions', form.NamedSection, 'actions', 'actions', _('Save mtdblock contents'), _('Click "Save mtdblock" to download specified mtdblock file. (NOTE: THIS FEATURE IS FOR PROFESSIONALS! )'));
+                       ss = o.subsection;
+
+                       o = ss.option(form.ListValue, 'mtdselect', _('Choose mtdblock'));
+                       procmtd.split(/\n/).forEach(function(ln) {
+                               var match = ln.match(/^mtd(\d+): .+ "(.+?)"$/);
+                               if (match)
+                                       o.value(match[1], match[2]);
+                       });
 
-               o = ss.option(form.Button, 'mtddownload', _('Download mtdblock'));
-               o.inputstyle = 'action important';
-               o.inputtitle = _('Save mtdblock');
-               o.onclick = L.bind(this.handleBlock, this, hostname);
+                       o = ss.option(form.Button, 'mtddownload', _('Download mtdblock'));
+                       o.inputstyle = 'action important';
+                       o.inputtitle = _('Save mtdblock');
+                       o.onclick = L.bind(this.handleBlock, this, hostname);
+               }
 
 
                o = s.option(form.SectionValue, 'actions', form.NamedSection, 'actions', 'actions', _('Flash new firmware image'),