video: mxsfb: call remove() when booting OS
authorAnatolij Gustschin <agust@denx.de>
Sat, 25 Jan 2020 22:44:56 +0000 (23:44 +0100)
committerAnatolij Gustschin <agust@denx.de>
Tue, 4 Feb 2020 22:04:28 +0000 (23:04 +0100)
Add DM_FLAG_OS_PREPARE flag to ensure that the driver's
remove() callback is invoked before booting the kernel.
This is required to stop the LCDIF controller. This was
the behaviour with old driver without DM_VIDEO support.
Without stopping the LCDIF we sometimes observe incorrect
Linux logo position.

Fixes: ae0760584b38 ("imx: mx6ul_14x14_evk: convert to DM_VIDEO")
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Reported-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
drivers/video/mxsfb.c

index c52981053e99ac31476a48f3d0e3d45dc3030295..c097682d00ae19f061684f96fb71509a052765d0 100644 (file)
@@ -429,6 +429,6 @@ U_BOOT_DRIVER(mxs_video) = {
        .bind   = mxs_video_bind,
        .probe  = mxs_video_probe,
        .remove = mxs_video_remove,
-       .flags  = DM_FLAG_PRE_RELOC,
+       .flags  = DM_FLAG_PRE_RELOC | DM_FLAG_OS_PREPARE,
 };
 #endif /* ifndef CONFIG_DM_VIDEO */