clk: renesas: Pass clock rate around as 64bit number internally
authorMarek Vasut <marek.vasut+renesas@gmail.com>
Thu, 31 May 2018 17:06:02 +0000 (19:06 +0200)
committerMarek Vasut <marek.vasut+renesas@gmail.com>
Fri, 1 Jun 2018 07:42:13 +0000 (09:42 +0200)
The PLL rate could be in the GHz range, which could overflow a 32bit
data type. Since the hardware is 64bit anyway, pass the clock rates
as 64bit number internally to avoid this.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
drivers/clk/renesas/clk-rcar-gen3.c

index 4f10fd6352b18375ace9256ea74917f41c915bcb..834cd5ac58b26e2eb390c59d18b8c2951d756fb1 100644 (file)
@@ -134,7 +134,7 @@ static int gen3_clk_disable(struct clk *clk)
        return renesas_clk_endisable(clk, priv->base, false);
 }
 
-static ulong gen3_clk_get_rate(struct clk *clk)
+static u64 gen3_clk_get_rate64(struct clk *clk)
 {
        struct gen3_clk_priv *priv = dev_get_priv(clk->dev);
        struct cpg_mssr_info *info = priv->info;
@@ -142,7 +142,8 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        const struct cpg_core_clk *core;
        const struct rcar_gen3_cpg_pll_config *pll_config =
                                        priv->cpg_pll_config;
-       u32 value, mult, prediv, postdiv, rate = 0;
+       u32 value, mult, prediv, postdiv;
+       u64 rate = 0;
        int i, ret;
 
        debug("%s[%i] Clock: id=%lu\n", __func__, __LINE__, clk->id);
@@ -154,8 +155,8 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        }
 
        if (renesas_clk_is_mod(clk)) {
-               rate = gen3_clk_get_rate(&parent);
-               debug("%s[%i] MOD clk: parent=%lu => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent);
+               debug("%s[%i] MOD clk: parent=%lu => rate=%llu\n",
                      __func__, __LINE__, parent.id, rate);
                return rate;
        }
@@ -168,14 +169,14 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        case CLK_TYPE_IN:
                if (core->id == info->clk_extal_id) {
                        rate = clk_get_rate(&priv->clk_extal);
-                       debug("%s[%i] EXTAL clk: rate=%u\n",
+                       debug("%s[%i] EXTAL clk: rate=%llu\n",
                              __func__, __LINE__, rate);
                        return rate;
                }
 
                if (core->id == info->clk_extalr_id) {
                        rate = clk_get_rate(&priv->clk_extalr);
-                       debug("%s[%i] EXTALR clk: rate=%u\n",
+                       debug("%s[%i] EXTALR clk: rate=%llu\n",
                              __func__, __LINE__, rate);
                        return rate;
                }
@@ -183,8 +184,8 @@ static ulong gen3_clk_get_rate(struct clk *clk)
                return -EINVAL;
 
        case CLK_TYPE_GEN3_MAIN:
-               rate = gen3_clk_get_rate(&parent) / pll_config->extal_div;
-               debug("%s[%i] MAIN clk: parent=%i extal_div=%i => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) / pll_config->extal_div;
+               debug("%s[%i] MAIN clk: parent=%i extal_div=%i => rate=%llu\n",
                      __func__, __LINE__,
                      core->parent, pll_config->extal_div, rate);
                return rate;
@@ -192,14 +193,14 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        case CLK_TYPE_GEN3_PLL0:
                value = readl(priv->base + CPG_PLL0CR);
                mult = (((value >> 24) & 0x7f) + 1) * 2;
-               rate = gen3_clk_get_rate(&parent) * mult;
-               debug("%s[%i] PLL0 clk: parent=%i mult=%u => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) * mult;
+               debug("%s[%i] PLL0 clk: parent=%i mult=%u => rate=%llu\n",
                      __func__, __LINE__, core->parent, mult, rate);
                return rate;
 
        case CLK_TYPE_GEN3_PLL1:
-               rate = gen3_clk_get_rate(&parent) * pll_config->pll1_mult;
-               debug("%s[%i] PLL1 clk: parent=%i mul=%i => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) * pll_config->pll1_mult;
+               debug("%s[%i] PLL1 clk: parent=%i mul=%i => rate=%llu\n",
                      __func__, __LINE__,
                      core->parent, pll_config->pll1_mult, rate);
                return rate;
@@ -207,14 +208,14 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        case CLK_TYPE_GEN3_PLL2:
                value = readl(priv->base + CPG_PLL2CR);
                mult = (((value >> 24) & 0x7f) + 1) * 2;
-               rate = gen3_clk_get_rate(&parent) * mult;
-               debug("%s[%i] PLL2 clk: parent=%i mult=%u => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) * mult;
+               debug("%s[%i] PLL2 clk: parent=%i mult=%u => rate=%llu\n",
                      __func__, __LINE__, core->parent, mult, rate);
                return rate;
 
        case CLK_TYPE_GEN3_PLL3:
-               rate = gen3_clk_get_rate(&parent) * pll_config->pll3_mult;
-               debug("%s[%i] PLL3 clk: parent=%i mul=%i => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) * pll_config->pll3_mult;
+               debug("%s[%i] PLL3 clk: parent=%i mul=%i => rate=%llu\n",
                      __func__, __LINE__,
                      core->parent, pll_config->pll3_mult, rate);
                return rate;
@@ -222,15 +223,15 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        case CLK_TYPE_GEN3_PLL4:
                value = readl(priv->base + CPG_PLL4CR);
                mult = (((value >> 24) & 0x7f) + 1) * 2;
-               rate = gen3_clk_get_rate(&parent) * mult;
-               debug("%s[%i] PLL4 clk: parent=%i mult=%u => rate=%u\n",
+               rate = gen3_clk_get_rate64(&parent) * mult;
+               debug("%s[%i] PLL4 clk: parent=%i mult=%u => rate=%llu\n",
                      __func__, __LINE__, core->parent, mult, rate);
                return rate;
 
        case CLK_TYPE_FF:
        case CLK_TYPE_GEN3_PE:          /* FIXME */
-               rate = (gen3_clk_get_rate(&parent) * core->mult) / core->div;
-               debug("%s[%i] FIXED clk: parent=%i mul=%i div=%i => rate=%u\n",
+               rate = (gen3_clk_get_rate64(&parent) * core->mult) / core->div;
+               debug("%s[%i] FIXED clk: parent=%i mul=%i div=%i => rate=%llu\n",
                      __func__, __LINE__,
                      core->parent, core->mult, core->div, rate);
                return rate;
@@ -243,9 +244,9 @@ static ulong gen3_clk_get_rate(struct clk *clk)
                        if (cpg_sd_div_table[i].val != value)
                                continue;
 
-                       rate = gen3_clk_get_rate(&parent) /
+                       rate = gen3_clk_get_rate64(&parent) /
                               cpg_sd_div_table[i].div;
-                       debug("%s[%i] SD clk: parent=%i div=%i => rate=%u\n",
+                       debug("%s[%i] SD clk: parent=%i div=%i => rate=%llu\n",
                              __func__, __LINE__,
                              core->parent, cpg_sd_div_table[i].div, rate);
 
@@ -255,7 +256,7 @@ static ulong gen3_clk_get_rate(struct clk *clk)
                return -EINVAL;
 
        case CLK_TYPE_GEN3_RPC:
-               rate = gen3_clk_get_rate(&parent);
+               rate = gen3_clk_get_rate64(&parent);
 
                value = readl(priv->base + core->offset);
 
@@ -272,7 +273,7 @@ static ulong gen3_clk_get_rate(struct clk *clk)
                          CPG_RPC_POSTDIV_MASK;
                rate /= postdiv + 1;
 
-               debug("%s[%i] RPC clk: parent=%i prediv=%i postdiv=%i => rate=%u\n",
+               debug("%s[%i] RPC clk: parent=%i prediv=%i postdiv=%i => rate=%llu\n",
                      __func__, __LINE__,
                      core->parent, prediv, postdiv, rate);
 
@@ -285,11 +286,16 @@ static ulong gen3_clk_get_rate(struct clk *clk)
        return -ENOENT;
 }
 
+static ulong gen3_clk_get_rate(struct clk *clk)
+{
+       return gen3_clk_get_rate64(clk);
+}
+
 static ulong gen3_clk_set_rate(struct clk *clk, ulong rate)
 {
        /* Force correct SD-IF divider configuration if applicable */
        gen3_clk_setup_sdif_div(clk);
-       return gen3_clk_get_rate(clk);
+       return gen3_clk_get_rate64(clk);
 }
 
 static int gen3_clk_of_xlate(struct clk *clk, struct ofnode_phandle_args *args)