- the archivers expect mode to be a mode_t, so do not trip signed/unsigned conversion...

diff --git a/include/libbb.h b/include/libbb.h
index cd192b9eb78abd8cad35df1b71380f7980dbeef1..57531e491f0f8883d805664c8f8b6920842f5b13 100644 (file)
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -228,7 +228,7 @@ extern void trim(char *s);
 extern char *skip_whitespace(const char *);
 extern char *skip_non_whitespace(const char *);
 
-extern const char *bb_mode_string(int mode);
+extern const char *bb_mode_string(mode_t mode);
 extern int is_directory(const char *name, int followLinks, struct stat *statBuf);
 extern int remove_file(const char *path, int flags);
 extern int copy_file(const char *source, const char *dest, int flags);

diff --git a/libbb/mode_string.c b/libbb/mode_string.c
index 01029bfeed9a9720dbd002f1f78cc2a82e5f3ffc..d3ff1837579912e87312a60870bc4fb83e568bc4 100644 (file)
--- a/libbb/mode_string.c
+++ b/libbb/mode_string.c
@@ -51,7 +51,7 @@ static const char type_chars[16] = "?pc?d?b?-?l?s???";
 /*                                  0123456789abcdef */
 static const char mode_chars[7] = "rwxSTst";
 
-const char *bb_mode_string(int mode)
+const char *bb_mode_string(mode_t mode)
 {
        static char buf[12];
        char *p = buf;
@@ -91,7 +91,7 @@ static const char type_chars[16] = "?pc?d?b?-?l?s???";
 /*                                  0123456789abcdef */
 static const char mode_chars[7] = "rwxSTst";
 
-const char *bb_mode_string(int mode)
+const char *bb_mode_string(mode_t mode)
 {
        static char buf[12];
        char *p = buf;