clk: mediatek: use unsigned type for returning the clk rate
authorFabien Parent <fparent@baylibre.com>
Thu, 17 Oct 2019 19:02:05 +0000 (21:02 +0200)
committerLukasz Majewski <lukma@denx.de>
Sun, 26 Jan 2020 11:03:06 +0000 (12:03 +0100)
mtk_clk_find_parent_rate is calling clk_get_rate to know the rate
of a parent clock. clk_get_rate returns a ulong, while
mtk_clk_find_parent_rate returns an int. This implicit cast creates
an issue for clock rates big enough to need the full 32 bits to
store its data. When that happen the clk rate will become incorrect
because of the implicit cast between ulong -> int -> ulong.

This commit change the return type of mtk_clk_find_parent_rate to
ulong.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
drivers/clk/mediatek/clk-mtk.c

index 09ae2d48601be11400339fc302de58f91a3aa799..c52537cedf3aa8b6a4c1920d7119ee50c5003720 100644 (file)
@@ -40,7 +40,7 @@
  * the accurate frequency.
  */
 static ulong mtk_clk_find_parent_rate(struct clk *clk, int id,
-                                   const struct driver *drv)
+                                     const struct driver *drv)
 {
        struct clk parent = { .id = id, };