luci-base: add description annotations to tblsection cells
authorJo-Philipp Wich <jo@mein.io>
Sun, 22 Jul 2018 15:40:07 +0000 (17:40 +0200)
committerJo-Philipp Wich <jo@mein.io>
Thu, 26 Jul 2018 18:28:30 +0000 (20:28 +0200)
Add a "data-description" attribute to CBI fields which have a description
set, this allows responsive design themes to render a field description
when decomposing the table grid.

Also reuse the precalculated "typename" property if it exists, instead of
deriving it from the template name yet again.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 8e0ee137a67c3e924c2a3827968b6f3f1d7ce9f4)

modules/luci-base/luasrc/view/cbi/cell_valueheader.htm

index dbb0e1120b83700ba030f9b13bd560caf0bdb5b2..ea0568f4097e490b4163c884412ad7a9b02e1be5 100644 (file)
@@ -1,10 +1,12 @@
 <%-
        local title = luci.util.trim(striptags(self.title))
-       local ftype = self.template and self.template:gsub("^.+/", "")
+       local descr = luci.util.trim(striptags(self.description))
+       local ftype = self.typename or (self.template and self.template:gsub("^.+/", ""))
 -%>
 <div class="td cbi-value-field<% if self.error and self.error[section] then %> cbi-value-error<% end %>"<%=
        attr("data-name", self.option) ..
        ifattr(ftype and #ftype > 0, "data-type", ftype) ..
-       ifattr(title and #title > 0, "data-title", title)
+       ifattr(title and #title > 0, "data-title", title) ..
+       ifattr(descr and #descr > 0, "data-description", descr)
 %>>
 <div id="cbi-<%=self.config.."-"..section.."-"..self.option%>" data-index="<%=self.index%>" data-depends="<%=pcdata(self:deplist2json(section))%>">