binman: Rename ReadContents() to ReadBlobContents()
authorSimon Glass <sjg@chromium.org>
Tue, 17 Jul 2018 19:25:50 +0000 (13:25 -0600)
committerSimon Glass <sjg@chromium.org>
Wed, 1 Aug 2018 22:30:48 +0000 (16:30 -0600)
This function name is too generic for its purpose and is therefore
confusing. It actually only applies to blobs, so rename it to indicate
this.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/binman/etype/blob.py
tools/binman/etype/u_boot_dtb_with_ucode.py
tools/binman/etype/u_boot_ucode.py

index 692d8683c3309c520e4e468759f1c98f36cfc516..3f46eecf308f5cc0b2e7d6e2e6e8bdf587748e07 100644 (file)
@@ -29,10 +29,10 @@ class Entry_blob(Entry):
     def ObtainContents(self):
         self._filename = self.GetDefaultFilename()
         self._pathname = tools.GetInputFilename(self._filename)
-        self.ReadContents()
+        self.ReadBlobContents()
         return True
 
-    def ReadContents(self):
+    def ReadBlobContents(self):
         with open(self._pathname) as fd:
             # We assume the data is small enough to fit into memory. If this
             # is used for large filesystem image that might not be true.
index adcb898a7b20187a61d3123da94cff2bf75c4fbc..285a28dd1e7437c5cf0ae574687b227a96124983 100644 (file)
@@ -71,7 +71,7 @@ class Entry_u_boot_dtb_with_ucode(Entry_blob):
         # Call the base class just in case it does something important.
         Entry_blob.ObtainContents(self)
         self._pathname = control.GetFdtPath(self._filename)
-        self.ReadContents()
+        self.ReadBlobContents()
         if self.ucode:
             for node in self.ucode.subnodes:
                 data_prop = node.props.get('data')
index 0f1761afc8f2486947635024ff9559d2a86664fb..6acf94d8cbc557ae0136c1157c518eb1408bf903 100644 (file)
@@ -92,6 +92,6 @@ class Entry_u_boot_ucode(Entry_blob):
             fd.write(fdt_entry.ucode_data)
 
         self._pathname = fname
-        self.ReadContents()
+        self.ReadBlobContents()
 
         return True