eliminate dead call from API

diff --git a/src/ats/ats_api_scheduling.c b/src/ats/ats_api_scheduling.c
index f02e4a9e76d53cc86c844d517e575dced67919fe..a0a196d1abfe5050d5bd1f3bc9652290875edc56 100644 (file)
--- a/src/ats/ats_api_scheduling.c
+++ b/src/ats/ats_api_scheduling.c
@@ -462,7 +462,7 @@ error_handler (void *cls,
 {
   struct GNUNET_ATS_SchedulingHandle *sh = cls;
 
-  LOG (GNUNET_ERROR_TYPE_WARNING,
+  LOG (GNUNET_ERROR_TYPE_ERROR,
        "ATS connection died (code %d), reconnecting\n",
        (int) error);
   force_reconnect (sh);
@@ -540,9 +540,11 @@ reconnect (struct GNUNET_ATS_SchedulingHandle *sh)
   struct GNUNET_ATS_AddressRecord *ar;
 
   GNUNET_assert (NULL == sh->client);
-  sh->client = GNUNET_CLIENT_connect ("ats", sh->cfg);
+  sh->client = GNUNET_CLIENT_connect ("ats",
+                                      sh->cfg);
   if (NULL == sh->client)
   {
+    GNUNET_break (0);
     force_reconnect (sh);
     return;
   }
@@ -632,29 +634,6 @@ GNUNET_ATS_scheduling_done (struct GNUNET_ATS_SchedulingHandle *sh)
 }
 
 
-/**
- * Test if a address and a session is known to ATS
- *
- * @param sh the scheduling handle
- * @param address the address
- * @param session the session
- * @return #GNUNET_YES or #GNUNET_NO
- */
-int
-GNUNET_ATS_session_known (struct GNUNET_ATS_SchedulingHandle *sh,
-                          const struct GNUNET_HELLO_Address *address,
-                          struct Session *session)
-{
-  if (NULL == session)
-    return GNUNET_NO;
-  if (NOT_FOUND != find_session_id (sh,
-                                    session,
-                                    address))
-    return GNUNET_YES;  /* Exists */
-  return GNUNET_NO;
-}
-
-
 /**
  * We have a new address ATS should know. Addresses have to be added
  * with this function before they can be: updated, set in use and

diff --git a/src/include/gnunet_ats_service.h b/src/include/gnunet_ats_service.h
index 8b28f5dc709ff21bb2a1ddd3aa4be41147f10a80..749e604fac69005ad31177a6362fb98a4dc90665 100644 (file)
--- a/src/include/gnunet_ats_service.h
+++ b/src/include/gnunet_ats_service.h
@@ -378,20 +378,6 @@ void
 GNUNET_ATS_scheduling_done (struct GNUNET_ATS_SchedulingHandle *sh);
 
 
-/**
- * Test if a address and a session is known to ATS.
- *
- * @param sh the scheduling handle
- * @param address the address
- * @param session the session
- * @return #GNUNET_YES or #GNUNET_NO
- */
-int
-GNUNET_ATS_session_known (struct GNUNET_ATS_SchedulingHandle *sh,
-                          const struct GNUNET_HELLO_Address *address,
-                          struct Session *session);
-
-
 /**
  * Handle used within ATS to track an address.
  */
@@ -485,7 +471,9 @@ struct GNUNET_ATS_PerformanceHandle;
  * Signature of a function that is called with QoS information about an address.
  *
  * @param cls closure
- * @param address the address, NULL if ATS service was disconnected
+ * @param address the address, NULL if ATS service was disconnected or
+ *        when the iteration is completed in the case of
+ *        #GNUNET_ATS_performance_list_addresses()
  * @param address_active #GNUNET_YES if this address is actively used
  *        to maintain a connection to a peer;
  *        #GNUNET_NO if the address is not actively used;
@@ -524,7 +512,6 @@ GNUNET_ATS_performance_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
                              void *addr_info_cb_cls);
 
 
-
 /**
  * Get information about addresses known to the ATS subsystem.
  *
@@ -535,7 +522,7 @@ GNUNET_ATS_performance_init (const struct GNUNET_CONFIGURATION_Handle *cfg,
  * @param infocb callback to call with the addresses,
  *        will callback with address == NULL when done
  * @param infocb_cls closure for @a infocb
- * @return ats performance context
+ * @return handle to abort the operation
  */
 struct GNUNET_ATS_AddressListHandle *
 GNUNET_ATS_performance_list_addresses (struct GNUNET_ATS_PerformanceHandle *handle,