bb_daemonize_or_rexec(): add flag to double-fork; use it in start-stop-daemon

Add a DAEMON_DOUBLE_FORK flag to make bb_daemonize double-fork so it isn't a
session leader, and hence doesn't get a controlling tty on Linux if a tty is
ever opened, similar to how libdaemon's daemon_fork or the big
start-stop-daemon does it - And use it in start-stop-daemon.

For details, see http://www.win.tue.nl/~aeb/linux/lk/lk-10.html#ss10.3

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

diff --git a/debianutils/start_stop_daemon.c b/debianutils/start_stop_daemon.c
index 02609c04fe8c30a52615547e2fcbff8b2d4aaf93..495ed0a0930468245ce73ac2ff209368de444dc4 100644 (file)
--- a/debianutils/start_stop_daemon.c
+++ b/debianutils/start_stop_daemon.c
@@ -474,7 +474,7 @@ int start_stop_daemon_main(int argc UNUSED_PARAM, char **argv)
        *--argv = startas;
        if (opt & OPT_BACKGROUND) {
 #if BB_MMU
-               bb_daemonize(DAEMON_DEVNULL_STDIO + DAEMON_CLOSE_EXTRA_FDS);
+               bb_daemonize(DAEMON_DEVNULL_STDIO + DAEMON_CLOSE_EXTRA_FDS + DAEMON_DOUBLE_FORK);
                /* DAEMON_DEVNULL_STDIO is superfluous -
                 * it's always done by bb_daemonize() */
 #else

diff --git a/include/libbb.h b/include/libbb.h
index 53224fa35bee7de65c6f3be24c2bcd188ba7043b..09e8d28e721954df473dc9217e54f810bc748c2a 100644 (file)
--- a/include/libbb.h
+++ b/include/libbb.h
@@ -966,6 +966,7 @@ enum {
        DAEMON_DEVNULL_STDIO = 2,
        DAEMON_CLOSE_EXTRA_FDS = 4,
        DAEMON_ONLY_SANITIZE = 8, /* internal use */
+       DAEMON_DOUBLE_FORK = 16, /* double fork to avoid controlling tty */
 };
 #if BB_MMU
   enum { re_execed = 0 };

diff --git a/libbb/vfork_daemon_rexec.c b/libbb/vfork_daemon_rexec.c
index a75eafbd3e96def9552a4b5386637d6081cfce57..ed1f86f0c5748383ba63b9c95253de72532e631e 100644 (file)
--- a/libbb/vfork_daemon_rexec.c
+++ b/libbb/vfork_daemon_rexec.c
@@ -253,11 +253,19 @@ void FAST_FUNC bb_daemonize_or_rexec(int flags, char **argv)
        if (!(flags & DAEMON_ONLY_SANITIZE)) {
                if (fork_or_rexec(argv))
                        exit(EXIT_SUCCESS); /* parent */
-               /* if daemonizing, make sure we detach from stdio & ctty */
+               /* if daemonizing, detach from stdio & ctty */
                setsid();
                dup2(fd, 0);
                dup2(fd, 1);
                dup2(fd, 2);
+               if (flags & DAEMON_DOUBLE_FORK) {
+                       /* On Linux, session leader can acquire ctty
+                        * unknowingly, by opening a tty.
+                        * Prevent this: stop being a session leader.
+                        */
+                       if (fork_or_rexec(argv))
+                               exit(EXIT_SUCCESS); /* parent */
+               }
        }
        while (fd > 2) {
                close(fd--);