fdt: Add a check to do_fdt() for coverity
authorSimon Glass <sjg@chromium.org>
Wed, 7 Jun 2017 16:28:41 +0000 (10:28 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 12 Jun 2017 12:38:08 +0000 (08:38 -0400)
We know that fdt_getprop() does not return NULL when len is > 0 but
coverity does not. Add an extra check to keep it happy.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163249)
Fixes: bc80295b (fdt: Add get commands to fdt)

cmd/fdt.c

index e55102a18d93361236a3b89dba8ad0e28c778091..dc0052040ab9f83c60b56a266775435b61ed8943 100644 (file)
--- a/cmd/fdt.c
+++ b/cmd/fdt.c
@@ -380,7 +380,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                                /* no property value */
                                setenv(var, "");
                                return 0;
-                       } else if (len > 0) {
+                       } else if (nodep && len > 0) {
                                if (subcmd[0] == 'v') {
                                        int ret;