make_single_applets: fix ": $((fail++))" expansion error
authorKang-Che Sung <explorer09@gmail.com>
Sat, 15 Jul 2017 03:38:58 +0000 (11:38 +0800)
committerDenys Vlasenko <vda.linux@googlemail.com>
Tue, 18 Jul 2017 17:20:58 +0000 (19:20 +0200)
$((fail++)) is not a required expression in POSIX, and in "dash" it
could produce an error like this:

    ./make_single_applets.sh: 61: arithmetic expression: expecting primary: "fail++"

Replace this with something portable: fail=$((fail+1)) would work.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
make_single_applets.sh

index 8ad7a7406375aadfaea551894a522ba3be9e0950..329a27d32ff17e857aab87b11f1fb4293a816e14 100755 (executable)
@@ -54,18 +54,18 @@ for app; do
        fi
 
        if ! yes '' | make oldconfig >busybox_make_${app}.log 2>&1; then
-               : $((fail++))
+               fail=$((fail+1))
                echo "Config error for ${app}"
                mv .config busybox_config_${app}
        elif ! make $makeopts >>busybox_make_${app}.log 2>&1; then
-               : $((fail++))
+               fail=$((fail+1))
                grep -i -e error: -e warning: busybox_make_${app}.log
                echo "Build error for ${app}"
                mv .config busybox_config_${app}
        elif ! grep -q '^#define NUM_APPLETS 1$' include/NUM_APPLETS.h; then
                grep -i -e error: -e warning: busybox_make_${app}.log
                mv busybox busybox_${app}
-               : $((fail++))
+               fail=$((fail+1))
                echo "NUM_APPLETS != 1 for ${app}: `cat include/NUM_APPLETS.h`"
                mv .config busybox_config_${app}
        else