projects
/
oweals
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
65e8ce2
)
bcm281xx: clock: avoid possible NULL dereference
author
xypron.glpk@gmx.de
<xypron.glpk@gmx.de>
Sun, 30 Jul 2017 18:27:16 +0000
(20:27 +0200)
committer
Tom Rini
<trini@konsulko.com>
Sun, 13 Aug 2017 19:17:27 +0000
(15:17 -0400)
It does not make sense first to dereference c and then
to check if it is NULL.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
arch/arm/cpu/armv7/bcm281xx/clk-core.c
patch
|
blob
|
history
diff --git
a/arch/arm/cpu/armv7/bcm281xx/clk-core.c
b/arch/arm/cpu/armv7/bcm281xx/clk-core.c
index cdc1264d7cd5d1c0ab7883220e553d47404aa198..b061c20648b8e2eaf326f89e9ca8aaf892b01cb3 100644
(file)
--- a/
arch/arm/cpu/armv7/bcm281xx/clk-core.c
+++ b/
arch/arm/cpu/armv7/bcm281xx/clk-core.c
@@
-479,9
+479,9
@@
unsigned long clk_get_rate(struct clk *c)
{
unsigned long rate;
- debug("%s: %s\n", __func__, c->name);
if (!c || !c->ops || !c->ops->get_rate)
return 0;
+ debug("%s: %s\n", __func__, c->name);
rate = c->ops->get_rate(c);
debug("%s: rate = %ld\n", __func__, rate);
@@
-493,9
+493,9
@@
int clk_set_rate(struct clk *c, unsigned long rate)
{
int ret;
- debug("%s: %s rate=%ld\n", __func__, c->name, rate);
if (!c || !c->ops || !c->ops->set_rate)
return -EINVAL;
+ debug("%s: %s rate=%ld\n", __func__, c->name, rate);
if (c->use_cnt)
return -EINVAL;