luci-base: cbi.js: use adjacent button dynlist add/remove buttons
authorJo-Philipp Wich <jo@mein.io>
Mon, 23 Jul 2018 12:31:40 +0000 (14:31 +0200)
committerJo-Philipp Wich <jo@mein.io>
Thu, 26 Jul 2018 18:30:44 +0000 (20:30 +0200)
Change the cbi.js code to create  a div based button element instead of an
image button.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 875b561875cb4eca4c913c69ce2dfd21265b6ac6)

modules/luci-base/htdocs/luci-static/resources/cbi.js

index 89dfac9e46a87e6611475498ce1e541b2490312e..9d79b81c19b4184014d202a9cedd41bfeb6501a6 100644 (file)
@@ -818,9 +818,9 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
                                t.placeholder = holder;
                        }
 
-                       var b = document.createElement('img');
-                               b.src = cbi_strings.path.resource + ((i+1) < values.length ? '/cbi/remove.gif' : '/cbi/add.gif');
-                               b.className = 'cbi-image-button';
+                       var b = E('div', {
+                               class: 'cbi-button cbi-button-' + ((i+1) < values.length ? 'remove' : 'add')
+                       }, (i+1) < values.length ? '×' : '+');
 
                        parent.appendChild(t);
                        parent.appendChild(b);
@@ -986,8 +986,7 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
                        input = input.previousSibling;
                }
 
-               if (se.src.indexOf('remove') > -1)
-               {
+               if (se.classList.contains('cbi-button-remove')) {
                        input.value = '';
 
                        cbi_dynlist_keydown({
@@ -995,8 +994,7 @@ function cbi_dynlist_init(parent, datatype, optional, choices)
                                keyCode: 8
                        });
                }
-               else
-               {
+               else {
                        cbi_dynlist_keydown({
                                target:  input,
                                keyCode: 13