mount: if FILE* is NULL, it's not wise to use it.
authorDenis Vlasenko <vda.linux@googlemail.com>
Sun, 19 Nov 2006 17:34:57 +0000 (17:34 -0000)
committerDenis Vlasenko <vda.linux@googlemail.com>
Sun, 19 Nov 2006 17:34:57 +0000 (17:34 -0000)
util-linux/mount.c

index 4069416d9ced7c39a4670a49f9649bd6048a91f4..027adc5680ed9fe0759c84c99ce5f22cb45ec63f 100644 (file)
@@ -261,14 +261,16 @@ static int mount_it_now(struct mntent *mp, int vfsflags, char *filteropts)
 
        /* If the mount was successful, and we're maintaining an old-style
         * mtab file by hand, add the new entry to it now. */
-mtab:
+ mtab:
        if (ENABLE_FEATURE_MTAB_SUPPORT && useMtab && !rc && !(vfsflags & MS_REMOUNT)) {
                char *fsname;
                FILE *mountTable = setmntent(bb_path_mtab_file, "a+");
                int i;
 
-               if (!mountTable)
+               if (!mountTable) {
                        bb_error_msg("no %s",bb_path_mtab_file);
+                       goto ret;
+               }
 
                // Add vfs string flags
 
@@ -300,7 +302,7 @@ mtab:
                        free(fsname);
                }
        }
-
+ ret:
        return rc;
 }