USB: gadget: atmel_usba_udc: fix transfer hang issue
authorBo Shen <voice.shen@atmel.com>
Mon, 15 Dec 2014 10:12:47 +0000 (18:12 +0800)
committerMarek Vasut <marex@denx.de>
Tue, 16 Dec 2014 15:08:50 +0000 (16:08 +0100)
When receive data, the RXRDY in status register set by hardware
after a new packet has been stored in the endpoint FIFO. After,
we copy from FIFO, we clear it, make the FIFO can be accessed
again.
In the receive_data() function, this bit RXRDY has been cleared.
So, after the receive_data() function return, this bit should
not be cleared again, or else it will cause the accessing FIFO
corrupt, which will make the data loss.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
drivers/usb/gadget/atmel_usba_udc.c

index 12628effe8bb978fe308352631c88f4ede7ec1f0..fbc74f3bed829a8bc2c8b6c88cf44306c415f5bc 100644 (file)
@@ -1062,7 +1062,6 @@ static void usba_ep_irq(struct usba_udc *udc, struct usba_ep *ep)
        if ((epstatus & epctrl) & USBA_RX_BK_RDY) {
                DBG(DBG_BUS, "%s: RX data ready\n", ep->ep.name);
                receive_data(ep);
-               usba_ep_writel(ep, CLR_STA, USBA_RX_BK_RDY);
        }
 }