Handle errors from TAP-Win32/64 adapter in a better way.
authorGuus Sliepen <guus@tinc-vpn.org>
Fri, 7 Feb 2014 15:34:08 +0000 (16:34 +0100)
committerGuus Sliepen <guus@tinc-vpn.org>
Fri, 7 Feb 2014 18:48:37 +0000 (19:48 +0100)
Before, the tapreader thread would just exit immediately after encountering the
first error, without notifying the main thread. Now, the tapreader thead never
exits itself, but tells the main thread to stop when more than ten errors are
encountered in a row.

src/mingw/device.c

index 56203d44939b789efb4c3b5f1f4b2a0d9faac4ff..441c52477ee6dd13a5f3480382c8c04bd84aea96 100644 (file)
@@ -49,6 +49,7 @@ static DWORD WINAPI tapreader(void *bla) {
        DWORD len;
        OVERLAPPED overlapped;
        vpn_packet_t packet;
+       int errors;
 
        logger(LOG_DEBUG, "Tap reader running");
 
@@ -71,13 +72,22 @@ static DWORD WINAPI tapreader(void *bla) {
                        } else {
                                logger(LOG_ERR, "Error while reading from %s %s: %s", device_info,
                                           device, strerror(errno));
-                               return -1;
+                               errors++;
+                               if(errors >= 10) {
+                                       EnterCriticalSection(&mutex);
+                                       running = false;
+                                       LeaveCriticalSection(&mutex);
+                               }
+                               usleep(1000000);
+                               continue;
                        }
                }
 
-               EnterCriticalSection(&mutex);
+               errors = 0;
                packet.len = len;
                packet.priority = 0;
+
+               EnterCriticalSection(&mutex);
                route(myself, &packet);
                LeaveCriticalSection(&mutex);
        }