Review comments; fail build if nits found

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2202)

diff --git a/.gitignore b/.gitignore
index 0a7edfc6c82627c51bc59cc647cf6c253fb24dc9..bf4a9dedf2dbcb3748b72233dfcc06f81a5aa965 100644 (file)
--- a/.gitignore
+++ b/.gitignore
@@ -177,3 +177,4 @@ pod2htmd.tmp
 
 # Windows manifest files
 *.manifest
+doc-nits

diff --git a/.travis.yml b/.travis.yml
index b6c87662dda0d8372ff349ca331c9b6bab59d9dc..a60c40289f0d006c97060970e42ee926e6acace2 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -29,9 +29,9 @@ compiler:
     - gcc
 
 env:
-    - CONFIG_OPTS="" DESTDIR="_install" CHECKDOCS="yes"
+    - CONFIG_OPTS="" DESTDIR="_install"
     - CONFIG_OPTS="--debug no-shared enable-crypto-mdebug enable-rc5 enable-md2"
-    - CONFIG_OPTS="no-pic --strict-warnings" BUILDONLY="yes"
+    - CONFIG_OPTS="no-pic --strict-warnings" BUILDONLY="yes" CHECKDOCS="yes"
     - CONFIG_OPTS="no-engine no-shared --strict-warnings" BUILDONLY="yes"
     - CONFIG_OPTS="no-stdio --strict-warnings" BUILDONLY="yes"
 

diff --git a/Configurations/unix-Makefile.tmpl b/Configurations/unix-Makefile.tmpl
index eefb50a8ea0874fe27c1d987f866def9a1f083f6..a2b197d3ee55de3cceb699838b760fcc2f87acf7 100644 (file)
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -323,9 +323,6 @@ install_sw: all install_dev install_engines install_runtime
 
 uninstall_sw: uninstall_runtime uninstall_engines uninstall_dev
 
-doc-nits:
-       $(PERL) util/find-doc-nits.pl -n
-
 install_docs: install_man_docs install_html_docs
 
 uninstall_docs: uninstall_man_docs uninstall_html_docs
@@ -677,6 +674,10 @@ update: generate errors ordinals
 generate: generate_apps generate_crypto_bn generate_crypto_objects \
           generate_crypto_conf generate_crypto_asn1
 
+doc-nits:
+       (cd $(SRCDIR); $(PERL) util/find-doc-nits.pl -n ) >doc-nits
+       if [ -s doc-nits ] ; then cat doc-nits; exit 1; fi
+
 # Test coverage is a good idea for the future
 #coverage: $(PROGRAMS) $(TESTPROGRAMS)
 #      ...