ash,hush: add TODO for rare build failure

*: remove some redundant includes

diff --git a/coreutils/dd.c b/coreutils/dd.c
index 8a40aa77f86cd0ac5a9bd3262763189159c997f8..38dacc71db5b4b1afa0ca3db27e732f615f87aa9 100644 (file)
--- a/coreutils/dd.c
+++ b/coreutils/dd.c
@@ -8,7 +8,6 @@
  * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
 
-#include <signal.h>  /* For FEATURE_DD_SIGNAL_HANDLING */
 #include "libbb.h"
 
 /* This is a NOEXEC applet. Be very careful! */

diff --git a/coreutils/tee.c b/coreutils/tee.c
index dc947c9358270f2d360812d560122e46a473b9e2..0f24246708a795279231aeb7b977df602ae713f2 100644 (file)
--- a/coreutils/tee.c
+++ b/coreutils/tee.c
@@ -11,7 +11,6 @@
 /* http://www.opengroup.org/onlinepubs/007904975/utilities/tee.html */
 
 #include "libbb.h"
-#include <signal.h>
 
 int tee_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int tee_main(int argc, char **argv)

diff --git a/libbb/bb_askpass.c b/libbb/bb_askpass.c
index c60ef3708986f0d7a9c519ff7480109d9f048141..c9764973333e1a519e80f1c28b5e4158675b7bbd 100644 (file)
--- a/libbb/bb_askpass.c
+++ b/libbb/bb_askpass.c
@@ -8,8 +8,6 @@
  * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
 
-#include <termios.h>
-
 #include "libbb.h"
 
 /* do nothing signal handler */

diff --git a/libbb/speed_table.c b/libbb/speed_table.c
index 646f9146b73082da63583313e46e0305dffb3321..05fe66c64562a4c4c4c3871b6913705bd756ddc3 100644 (file)
--- a/libbb/speed_table.c
+++ b/libbb/speed_table.c
@@ -7,7 +7,6 @@
  * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
 
-#include <termios.h>
 #include "libbb.h"
 
 struct speed_map {

diff --git a/networking/telnet.c b/networking/telnet.c
index ba6f2fb8326cef6bf1efc949413f2dc85a37172d..cc994250c81303db69d0ef465d67f22392d8bbd0 100644 (file)
--- a/networking/telnet.c
+++ b/networking/telnet.c
@@ -21,7 +21,6 @@
  *
  */
 
-#include <termios.h>
 #include <arpa/telnet.h>
 #include <netinet/in.h>
 #include "libbb.h"

diff --git a/procps/top.c b/procps/top.c
index 1d22871f68486be760a0027905a26a2271d9ac89..c8a9539d663cbab66ace5801d88c3b99749861e5 100644 (file)
--- a/procps/top.c
+++ b/procps/top.c
@@ -644,8 +644,6 @@ static void clearmems(void)
 }
 
 #if ENABLE_FEATURE_USE_TERMIOS
-#include <termios.h>
-#include <signal.h>
 
 static void reset_term(void)
 {

diff --git a/shell/ash.c b/shell/ash.c
index 55a79a7a621a2f8c98b20cb431e448db5414bdfe..66bfa67ba305283aa4fcf344497d79f529240e65 100644 (file)
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -53,11 +53,21 @@
 #endif
 
 #include "busybox.h" /* for applet_names */
+//TODO: pull in some .h and find out do we have SINGLE_APPLET_MAIN?
+//#include "applet_tables.h" doesn't work
 #include <paths.h>
 #include <setjmp.h>
 #include <fnmatch.h>
-#if JOBS || ENABLE_ASH_READ_NCHARS
-#include <termios.h>
+
+#if defined SINGLE_APPLET_MAIN
+/* STANDALONE does not make sense, and won't compile */
+#undef CONFIG_FEATURE_SH_STANDALONE
+#undef ENABLE_FEATURE_SH_STANDALONE
+#undef USE_FEATURE_SH_STANDALONE
+#undef SKIP_FEATURE_SH_STANDALONE(...)
+#define ENABLE_FEATURE_SH_STANDALONE 0
+#define USE_FEATURE_SH_STANDALONE(...)
+#define SKIP_FEATURE_SH_STANDALONE(...) __VA_ARGS__
 #endif
 
 #ifndef PIPE_BUF

diff --git a/shell/hush.c b/shell/hush.c
index 421272971a3a39fe5075ab6cae64a1ca2a864b84..eafcbb4c9adc1031018838e7b177fdf5e28da244 100644 (file)
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -67,6 +67,8 @@
  */
 
 #include "busybox.h" /* for APPLET_IS_NOFORK/NOEXEC */
+//TODO: pull in some .h and find out do we have SINGLE_APPLET_MAIN?
+//#include "applet_tables.h" doesn't work
 #include <glob.h>
 /* #include <dmalloc.h> */
 #if ENABLE_HUSH_CASE
@@ -75,6 +77,17 @@
 
 #define HUSH_VER_STR "0.91"
 
+#if defined SINGLE_APPLET_MAIN
+/* STANDALONE does not make sense, and won't compile */
+#undef CONFIG_FEATURE_SH_STANDALONE
+#undef ENABLE_FEATURE_SH_STANDALONE
+#undef USE_FEATURE_SH_STANDALONE
+#define SKIP_FEATURE_SH_STANDALONE(...) __VA_ARGS__
+#define ENABLE_FEATURE_SH_STANDALONE 0
+#define USE_FEATURE_SH_STANDALONE(...)
+#define SKIP_FEATURE_SH_STANDALONE(...) __VA_ARGS__
+#endif
+
 #if !BB_MMU && ENABLE_HUSH_TICK
 //#undef ENABLE_HUSH_TICK
 //#define ENABLE_HUSH_TICK 0

diff --git a/util-linux/more.c b/util-linux/more.c
index cf8e137eb56d6c4680b3de3cfce34547e7b4b407..b0f20c441db1baffe3c20d343cb31aef28a692bc 100644 (file)
--- a/util-linux/more.c
+++ b/util-linux/more.c
@@ -15,10 +15,6 @@
  */
 
 #include "libbb.h"
-#if ENABLE_FEATURE_USE_TERMIOS
-#include <termios.h>
-#endif /* FEATURE_USE_TERMIOS */
-
 
 #if ENABLE_FEATURE_USE_TERMIOS