- add FIXME. Perhaps somebody is interrested in looking into this one.

  We would try to be clever and compare the *data instead of the *elt.

Somethink like this might be of more general use:
/* Unlink arbitrary element from the list that contains data */
void llist_unlink_data(llist_t **head, void *data)
{
    llist_t *elt;

    for (elt = *head; elt; elt = elt->link) {
        if (elt->data == data) {
            llist_unlink(elt);
            return;
        }
    }
}

diff --git a/modutils/depmod.c b/modutils/depmod.c
index 09d31f4c061b6d2c9b5d7231985315b828f845b3..733cd95bf04fc963c270c6a2672811c7e100546d 100644 (file)
--- a/modutils/depmod.c
+++ b/modutils/depmod.c
@@ -221,7 +221,7 @@ int depmod_main(int ATTRIBUTE_UNUSED argc, char **argv)
                                if (!strcmp(all->name, deps->data)) {
                                        llist_t *implied = all->dependencies;
                                        while (implied) {
-                                               /* erm, nicer would be to just
+                                               /* XXX:FIXME: erm, it would be nicer to just
                                                 * llist_unlink(&mods->dependencies, implied)  */
                                                llist_t *prune = mods->dependencies;
                                                while (prune) {