Fix test (#71)

* Fix timeouting tests

* Increase timeout to be sure requests will be propagated

* Add timeout to be sure video views will be updated

* Use standard style

* Fix PR comments.

diff --git a/server/tests/api/check-params/users.js b/server/tests/api/check-params/users.js
index 0ba5e77c386319c49518fce9307150c743845107..2c1189f7a590754e239e9a353517c542b3194770 100644 (file)
--- a/server/tests/api/check-params/users.js
+++ b/server/tests/api/check-params/users.js
@@ -23,7 +23,7 @@ describe('Test users API validators', function () {
   // ---------------------------------------------------------------
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     series([
       function (next) {

diff --git a/server/tests/api/check-params/video-blacklists.js b/server/tests/api/check-params/video-blacklists.js
index a39ab0cfa5624ba2f959bf072aaccdd66815d9b1..53b503e5613010c737fd6b19e5b99c743fcc5398 100644 (file)
--- a/server/tests/api/check-params/video-blacklists.js
+++ b/server/tests/api/check-params/video-blacklists.js
@@ -17,7 +17,7 @@ describe('Test video blacklists API validators', function () {
   // ---------------------------------------------------------------
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     series([
       function (next) {

diff --git a/server/tests/api/check-params/videos.js b/server/tests/api/check-params/videos.js
index ec4cc4ce87c113c419e903cbefc7069b5fdac44c..ce6c495832bea3116bd2a74995b7eeeaeda80323 100644 (file)
--- a/server/tests/api/check-params/videos.js
+++ b/server/tests/api/check-params/videos.js
@@ -378,7 +378,7 @@ describe('Test videos API validator', function () {
     })
 
     it('Should succeed with the correct parameters', function (done) {
-      this.timeout(5000)
+      this.timeout(10000)
 
       const data = {
         name: 'my super name',
@@ -392,6 +392,7 @@ describe('Test videos API validator', function () {
       const attach = {
         'videofile': pathUtils.join(__dirname, '..', 'fixtures', 'video_short.webm')
       }
+
       requestsUtils.makePostUploadRequest(server.url, path, server.accessToken, data, attach, function () {
         attach.videofile = pathUtils.join(__dirname, '..', 'fixtures', 'video_short.mp4')
         requestsUtils.makePostUploadRequest(server.url, path, server.accessToken, data, attach, function () {

diff --git a/server/tests/api/config.js b/server/tests/api/config.js
index 08f955f2d09f44119aa77e65afb732af7faaf181..e79e12823b3b6fdca9259b7fe0fb9eb574f8f704 100644 (file)
--- a/server/tests/api/config.js
+++ b/server/tests/api/config.js
@@ -13,7 +13,7 @@ describe('Test config', function () {
   let server = null
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     series([
       function (next) {

diff --git a/server/tests/api/friends-advanced.js b/server/tests/api/friends-advanced.js
index d433e97d02a78582d5836f2030c77ffb9f60651f..237cb533d53c60542ae808059ee85f04456ea27d 100644 (file)
--- a/server/tests/api/friends-advanced.js
+++ b/server/tests/api/friends-advanced.js
@@ -46,7 +46,7 @@ describe('Test advanced friends', function () {
   // ---------------------------------------------------------------
 
   before(function (done) {
-    this.timeout(30000)
+    this.timeout(120000)
     serversUtils.flushAndRunMultipleServers(6, function (serversRun, urlsRun) {
       servers = serversRun
 

diff --git a/server/tests/api/friends-basic.js b/server/tests/api/friends-basic.js
index 658e54829b62cf75ec92763637bede4847396873..4c2043b3984f0432aff3150940bf04f9428877e7 100644 (file)
--- a/server/tests/api/friends-basic.js
+++ b/server/tests/api/friends-basic.js
@@ -47,7 +47,7 @@ describe('Test basic friends', function () {
   // ---------------------------------------------------------------
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
     serversUtils.flushAndRunMultipleServers(3, function (serversRun, urlsRun) {
       servers = serversRun
 
@@ -76,7 +76,7 @@ describe('Test basic friends', function () {
   })
 
   it('Should make friends', function (done) {
-    this.timeout(40000)
+    this.timeout(120000)
 
     series([
       // The second pod make friend with the third
@@ -142,11 +142,14 @@ describe('Test basic friends', function () {
   })
 
   it('Should not be allowed to make friend again', function (done) {
+    this.timeout(10000)
     const server = servers[1]
     podsUtils.makeFriends(server.url, server.accessToken, 409, done)
   })
 
   it('Should quit friends of pod 2', function (done) {
+    this.timeout(10000)
+
     series([
       // Pod 1 quit friends
       function (next) {
@@ -183,7 +186,7 @@ describe('Test basic friends', function () {
   })
 
   it('Should allow pod 2 to make friend again', function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     const server = servers[1]
     podsUtils.makeFriends(server.url, server.accessToken, function () {

diff --git a/server/tests/api/multiple-pods.js b/server/tests/api/multiple-pods.js
index c1b5fc9f5bb7574fbeb12291c554efa359536dd2..c3ee77f0c98f73d2b07b364679909c69bcdf58f3 100644 (file)
--- a/server/tests/api/multiple-pods.js
+++ b/server/tests/api/multiple-pods.js
@@ -22,7 +22,7 @@ describe('Test multiple pods', function () {
   const toRemove = []
 
   before(function (done) {
-    this.timeout(30000)
+    this.timeout(120000)
 
     series([
       // Run servers
@@ -230,7 +230,7 @@ describe('Test multiple pods', function () {
     })
 
     it('Should upload two videos on pod 3 and propagate on each pod', function (done) {
-      this.timeout(30000)
+      this.timeout(45000)
 
       series([
         function (next) {
@@ -260,7 +260,7 @@ describe('Test multiple pods', function () {
           videosUtils.uploadVideo(servers[2].url, servers[2].accessToken, videoAttributes, next)
         },
         function (next) {
-          setTimeout(next, 22000)
+          setTimeout(next, 33000)
         }],
         function (err) {
           if (err) throw err

diff --git a/server/tests/api/request-schedulers.js b/server/tests/api/request-schedulers.js
index c5c443f14f1c29375147469f8ea9694047a0236e..c5ea72a6a1d3ce74cc4cb626939bde2c07a79762 100644 (file)
--- a/server/tests/api/request-schedulers.js
+++ b/server/tests/api/request-schedulers.js
@@ -37,7 +37,7 @@ describe('Test requests schedulers stats', function () {
   // ---------------------------------------------------------------
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
     serversUtils.flushAndRunMultipleServers(2, function (serversRun, urlsRun) {
       servers = serversRun
 

diff --git a/server/tests/api/single-pod.js b/server/tests/api/single-pod.js
index fe388698f9b24407719a350eded938f06078dc09..e08da05172b0fe1a018210444a8bc7591920bd3c 100644 (file)
--- a/server/tests/api/single-pod.js
+++ b/server/tests/api/single-pod.js
@@ -22,7 +22,7 @@ describe('Test a single pod', function () {
   let videosListBase = null
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     series([
       function (next) {
@@ -181,7 +181,8 @@ describe('Test a single pod', function () {
         if (err) throw err
         expect(test).to.equal(true)
 
-        done()
+       // Wait the async views increment
+        setTimeout(done, 500)
       })
     })
   })

diff --git a/server/tests/api/users.js b/server/tests/api/users.js
index 10c96baeb2eadad653275526ad111a0207c61384..74477ae2d8db11ec1525e11f9a9dd017974fb9fb 100644 (file)
--- a/server/tests/api/users.js
+++ b/server/tests/api/users.js
@@ -21,7 +21,7 @@ describe('Test users', function () {
   let userId = null
 
   before(function (done) {
-    this.timeout(20000)
+    this.timeout(120000)
 
     series([
       function (next) {

diff --git a/server/tests/api/video-abuse.js b/server/tests/api/video-abuse.js
index c2b6186bd8bef6fed88acae71329a8d1c0257a65..be35a361dacff8b46c7ba9edea03c69ee4350a17 100644 (file)
--- a/server/tests/api/video-abuse.js
+++ b/server/tests/api/video-abuse.js
@@ -17,7 +17,7 @@ describe('Test video abuses', function () {
   let servers = []
 
   before(function (done) {
-    this.timeout(40000)
+    this.timeout(100000)
 
     series([
       // Run servers

diff --git a/server/tests/api/video-blacklist.js b/server/tests/api/video-blacklist.js
index 20b7c5de3b7c509d7258e1b6d878c06edfb0a2d2..79a2fec8d33195afce722da50346063bfbb0e4da 100644 (file)
--- a/server/tests/api/video-blacklist.js
+++ b/server/tests/api/video-blacklist.js
@@ -17,7 +17,7 @@ describe('Test video blacklists', function () {
   let servers = []
 
   before(function (done) {
-    this.timeout(40000)
+    this.timeout(120000)
 
     series([
       // Run servers