Server::step throw is never catched. Replace it with an errorstream + assert

This throw can be trigger by LuaError exception or ConnectionBindFailed exception in the following functions:
* EmergeThread::Thread()
* ScriptApiEnv::environment_Step()
* ScriptApiEnv::player_event()
* ServerThread::Thread()

diff --git a/src/server.cpp b/src/server.cpp
index 35405851fa85260240b44fe41f0de61c4a98de7f..4e955e40a410b8044959cdd73ef0021aee37d069 100644 (file)
--- a/src/server.cpp
+++ b/src/server.cpp
@@ -479,10 +479,13 @@ void Server::step(float dtime)
                JMutexAutoLock lock(m_step_dtime_mutex);
                m_step_dtime += dtime;
        }
-       // Throw if fatal error occurred in thread
+       // Assert if fatal error occurred in thread
        std::string async_err = m_async_fatal_error.get();
-       if(async_err != ""){
-               throw ServerError(async_err);
+       if(async_err != "") {
+               errorstream << "UNRECOVERABLE error occurred. Stopping server. "
+                               << "Please fix the following error:" << std::endl
+                               << async_err << std::endl;
+               assert(false);
        }
 }