udhcp: trivial shrink
authorDenys Vlasenko <vda.linux@googlemail.com>
Fri, 26 Feb 2016 13:56:18 +0000 (14:56 +0100)
committerDenys Vlasenko <vda.linux@googlemail.com>
Fri, 26 Feb 2016 13:56:18 +0000 (14:56 +0100)
function                                             old     new   delta
dname_dec                                            337     332      -5

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
networking/udhcp/domain_codec.c

index c1325d8be947ce6a9ba13dc88be75854dde3403b..05cdf51e980505f13fe6404a7cdaa32a5e65b6bd 100644 (file)
@@ -42,7 +42,7 @@ char* FAST_FUNC dname_dec(const uint8_t *cstr, int clen, const char *pre)
         */
        while (1) {
                /* note: "return NULL" below are leak-safe since
-                * dst isn't yet allocated */
+                * dst isn't allocated yet */
                const uint8_t *c;
                unsigned crtpos, retpos, depth, len;
 
@@ -95,9 +95,8 @@ char* FAST_FUNC dname_dec(const uint8_t *cstr, int clen, const char *pre)
                if (!dst) { /* first pass? */
                        /* allocate dst buffer and copy pre */
                        unsigned plen = strlen(pre);
-                       ret = dst = xmalloc(plen + len);
-                       memcpy(dst, pre, plen);
-                       dst += plen;
+                       ret = xmalloc(plen + len);
+                       dst = stpcpy(ret, pre);
                } else {
                        dst[len - 1] = '\0';
                        break;