Global new() or grab() to be managed in constuctor only (#7235 partial) (#7236)

* g_extrusion_mesh_cache new() and grab() to be managed in constuctor only (#7235 partial)

This global was getting grab()-ed by each call to getItemMesh, incrementing its reference count. What was to be the final drop() in the destructor ended up with > 0 reference count, so memory not freed by Irrlicht.

diff --git a/src/wieldmesh.cpp b/src/wieldmesh.cpp
index 7414701b783d91b26215790b28b4feeaf9083310..7791a5a92e71482fd2eb1d8a6c3039ca75e58a49 100644 (file)
--- a/src/wieldmesh.cpp
+++ b/src/wieldmesh.cpp
@@ -501,12 +501,8 @@ void getItemMesh(Client *client, const ItemStack &item, ItemMesh *result)
        const ContentFeatures &f = ndef->get(def.name);
        content_t id = ndef->getId(def.name);
 
-       if (!g_extrusion_mesh_cache) {
-               g_extrusion_mesh_cache = new ExtrusionMeshCache();
-       } else {
-               g_extrusion_mesh_cache->grab();
-       }
-
+       FATAL_ERROR_IF(!g_extrusion_mesh_cache, "Extrusion mesh cache is not yet initialized");
+       
        scene::SMesh *mesh = nullptr;
 
        // Shading is on by default