Fix a double free in ca command line
authorMatt Caswell <matt@openssl.org>
Mon, 10 Oct 2016 15:53:11 +0000 (16:53 +0100)
committerMatt Caswell <matt@openssl.org>
Fri, 28 Oct 2016 08:35:03 +0000 (09:35 +0100)
Providing a spkac file with no default section causes a double free.

Thanks to Brian Carpenter for reporting this issue.

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
(cherry picked from commit 229bd12487f8576fc088dc4f641950ac33c62033)

apps/ca.c

index 20c4ebb0433b55c80996f6fd8f78e684a6dfb444..4cea3cb7b1cea8177f1ed70e5b21c68e93f8fdbb 100644 (file)
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -2224,7 +2224,6 @@ static int certify_spkac(X509 **xret, char *infile, EVP_PKEY *pkey,
     sk = CONF_get_section(parms, "default");
     if (sk_CONF_VALUE_num(sk) == 0) {
         BIO_printf(bio_err, "no name/value pairs found in %s\n", infile);
-        CONF_free(parms);
         goto err;
     }