arm64: zynqmp: remove unnecessary logical constraint
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Thu, 12 Oct 2017 23:14:27 +0000 (01:14 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 28 Nov 2017 14:53:07 +0000 (15:53 +0100)
In

if (a || b)
else if (!a)

the constraint (!a) is always true if else is reached and
can be removed.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
arch/arm/cpu/armv8/zynqmp/cpu.c

index 1b5066a8266df2824ed28235088024fd6d5f5fe6..9b83e51885fa0681b9334358880db3fe12df61cd 100644 (file)
@@ -198,7 +198,7 @@ int zynqmp_mmio_write(const u32 address,
 {
        if (IS_ENABLED(CONFIG_SPL_BUILD) || current_el() == 3)
                return zynqmp_mmio_rawwrite(address, mask, value);
-       else if (!IS_ENABLED(CONFIG_SPL_BUILD))
+       else
                return invoke_smc(ZYNQMP_MMIO_WRITE, address, mask,
                                  value, 0, NULL);
 
@@ -215,7 +215,7 @@ int zynqmp_mmio_read(const u32 address, u32 *value)
 
        if (IS_ENABLED(CONFIG_SPL_BUILD) || current_el() == 3) {
                ret = zynqmp_mmio_rawread(address, value);
-       } else if (!IS_ENABLED(CONFIG_SPL_BUILD)) {
+       } else {
                ret = invoke_smc(ZYNQMP_MMIO_READ, address, 0, 0,
                                 0, ret_payload);
                *value = ret_payload[1];