gavinl writes in Bug 661:

if read() file return less than 1, we should close the fd and then goto end.

diff --git a/util-linux/mdev.c b/util-linux/mdev.c
index b8c0090fae72d34d21713933c48db010e7d1e240..8f23120609b655987e1decc965cdb6df4335e63b 100644 (file)
--- a/util-linux/mdev.c
+++ b/util-linux/mdev.c
@@ -42,8 +42,8 @@ static void make_device(char *path)
        snprintf(temp, PATH_MAX, "%s/dev", path);
        fd = open(temp, O_RDONLY);
        len = read(fd, temp, PATH_MAX-1);
-       if (len<1) goto end;
        close(fd);
+       if (len<1) goto end;
 
        /* Determine device name, type, major and minor */